Skip to content

allow specifying which QBXML errors should be fatal #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elemecca wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow specifying which QBXML errors should be fatal #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions QuickBooks/WebConnector/Handlers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,8 @@ protected function _defaults($config)
'deny_reallyfast_timeout' => 600,

'masking' => true,

'status_error_threshold' => 1, // the lowest status code considered an error
);

$config = array_merge($defaults, $config);
Expand Down Expand Up @@ -347,6 +349,8 @@ protected function _defaults($config)
$config['deny_reallyfast_logins'] = (boolean) $config['deny_reallyfast_logins'];
$config['deny_reallyfast_timeout'] = (int) max(1, $config['deny_reallyfast_timeout']);

$config['status_error_threshold'] = (int) max(1, $config['status_error_threshold']);

return $config;
}

Expand Down Expand Up @@ -1287,8 +1291,9 @@ public function receiveResponseXML($obj)
$this->_log('Incoming XML response: ' . $obj->response, $obj->ticket, QUICKBOOKS_LOG_DEBUG);

// Check if we got a error message...
if (strlen($obj->message) or
$this->_extractStatusCode($obj->response)) // or an error code
if (strlen($obj->message) or
$this->_extractStatusCode($obj->response)
>= $this->_config['status_error_threshold']) // or an error code
{
//$this->_log('Extracted code[' . $this->_extractStatusCode($obj->response) . ']', $obj->ticket, QUICKBOOKS_LOG_DEBUG);

Expand Down