allow specifying which QBXML errors should be fatal#202
Open
Elemecca wants to merge 1 commit into
Open
Conversation
Currently any nonzero status code received in the XML sent to `receiveResponseXML` is considered a fatal error and the QBWC session is torn down. That's incorrect according to the QBXML documentation, which says that codes 1-499 are informational and 500-999 are warnings. This adds a new configuration key, `status_error_threshold`, which is the minimum status code which should be considered a fatal error. To preserve reverse compatibility the default is set to 1.
Elemecca
force-pushed
the
t-error-threshold
branch
from
564520a to
25bdc4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently any nonzero status code received in the XML sent to
receiveResponseXMLis considered a fatal error and the QBWC session is torn down. That's incorrect according to the QBXML documentation, which says that codes 1-499 are informational and 500-999 are warnings. This adds a new configuration key,status_error_threshold, which is the minimum status code which should be considered a fatal error. To preserve reverse compatibility the default is set to 1.