[VISUALIZATION] [GCC16] cleanup for unused variables

[smuzaffar]

Cleanup set but unused variables which are causing build errors for GCC16 IBs https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/el9_amd64_gcc16/www/tue/17.0-tue-23/CMSSW_17_0_X_2026-05-19-2300

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50994/49409

• There are other open Pull requests which might conflict with changes you have proposed:
  • File Fireworks/Core/src/CmsShowCommon.cc modified in PR(s): [Do not merge] Fixes for GCC16 #50988, [VISUALIZATION] [GCC16] cleanup for unused variables #50989
  • File Fireworks/Core/src/FWModelChangeManager.cc modified in PR(s): [Do not merge] Fixes for GCC16 #50988, [VISUALIZATION] [GCC16] cleanup for unused variables #50989
  • File Fireworks/ParticleFlow/plugins/FWPFCandidateWithHitsProxyBuilder.cc modified in PR(s): [Do not merge] Fixes for GCC16 #50988, [VISUALIZATION] [GCC16] cleanup for unused variables #50989

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• Fireworks/Core (visualization)
• Fireworks/ParticleFlow (visualization)

@Dr15Jones, @alja, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46d082/53367/summary.html
COMMIT: 9ec755b
CMSSW: CMSSW_17_0_X_2026-05-19-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50994/53367/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4198477
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4198448
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 227 log files, 197 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1