BuildFile dependency cleaning, 1st round#50916
Open
dan131riley wants to merge 2 commits into
Open
Conversation
cmsbuild
added
reconstruction-pending
simulation-pending
dqm-pending
l1-pending
hlt-pending
core-pending
analysis-pending
alca-pending
daq-pending
fastsim-pending
db-pending
generators-pending
geometry-pending
pending-signatures
tests-pending
orp-pending
pdmv-pending
code-checks-pending
xpog-pending
heterogeneous-pending
tracking
trk
labels
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50916/49295
|
Contributor
|
A new Pull Request was created by @dan131riley for master. It involves the following packages:
@AdrianoDee, @Alejandro1400, @BenjaminRS, @DickyChant, @Dr15Jones, @JanChyczynski, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @arunhep, @atpathak, @battibass, @bsunanda, @civanch, @cmsbuild, @ctarricone, @emeschi, @francescobrivio, @ftorrresd, @fwyzard, @gabrielmscampos, @jfernan2, @kfjack, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @miquork, @mkirsano, @mmusich, @nothingface0, @perrotta, @quinnanm, @rseidita, @sensrcn, @smorovic, @smuzaffar, @srimanob, @sroychow, @ssekmen, @theofil, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
@cmsbuild please test |
Member
|
+dqm |
symbols that would be resolved from DataFormats/Provenance. As a result: - Several instances setting `source_only` were reverted to linking to the shared object, especially FWCore - Many packages were missing dependencies on `DataFormats/Provenance`, which have now been added. - An apparently spurious dependency on `ModuleDescription` was removed from RecoTracker/DeDx
dan131riley
force-pushed
the
dependencies-cleanup
branch
from
5a9ee57 to
592b438
Compare
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50916/49376
|
Contributor
|
Pull request #50916 was updated. @AdrianoDee, @Alejandro1400, @BenjaminRS, @DickyChant, @Dr15Jones, @JanChyczynski, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @arunhep, @atpathak, @battibass, @civanch, @cmsbuild, @ctarricone, @emeschi, @francescobrivio, @ftorrresd, @fwyzard, @gabrielmscampos, @jfernan2, @kfjack, @kpedro88, @lviliani, @makortel, @mandrenguyen, @mdhildreth, @miquork, @mkirsano, @mmusich, @perrotta, @quinnanm, @rseidita, @sensrcn, @smorovic, @smuzaffar, @srimanob, @sroychow, @theofil, @tvami can you please check and sign again. |
Contributor
|
+1 |
Contributor
|
+l1 |
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
Member
|
+dqm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is the first pass of some dependency cleanups.
General changes:
rootcling. See Add missing dependence on ROOT to CondFormats/MLObjects #50692 for motivation.DataFormats/Provenancetosource_only="1". Outside of IO modules and FWCore, most uses ofDataFormats/Provenanceare for one of a few elementary types likeedm::EventIDoredm::Timestamp. These uses do not need the dependency onFWCore/ReflectionthatDataFormats/Provenancebrings in. A future PR may move the core types into a separate package.rootmathtorootmathcore.boostandclhepSpecific changes:
CalibCalorimetry/EBPhase2TPGToolstoOnlineDB/EcalCondDB. TheOnlineDBpulls in the Oracle client libraries, which is undesirable. See When building some libraries, get error about libnsl.so being missing #50279.ModuleDescriptioninRecoTracker/DeDx/plugins/HLTDeDxFilter.ccResolves cms-sw/framework-team#1973
PR validation:
Compiles. No changes that should affect physics or computational performance.