Properly Counting maxDepth as no. of Doublets in the CA

[AdrianoDee]

PR description:

This PR proposes a small fix to the issue seen in #49525. The problem was actually understood by @elusian, and it's due to the fact that maxDepth is the max number of CACells that can compose an n-Tuplet. This means each track can have up to maxDepth + 1 hits. The container is sized to be maxDepth + 2 to take into account the extra fishbone hits. But it should actually be maxDepth + 1 + 2.

PR validation:

cmsDriver.py step2  -s DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:@relvalRun4 --conditions auto:phase2_realistic_T35 --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry ExtendedRun4D121 --era Phase2C22I13M9 --pileup AVE_200_BX_25ns --pileup_input das:/RelValMinBias_14TeV/CMSSW_16_0_0_pre2-150X_mcRun4_realistic_v1_STD_RegeneratedGS_Run4D121_noPU-v1/GEN-SIM --filein /store/user/cmsbuild/store/relval/CMSSW_16_0_0_pre2/RelValTTbar_14TeV/GEN-SIM/150X_mcRun4_realistic_v1_STD_RegeneratedGS_Run4D121_noPU-v1/2580000/2dbf40fb-f8dd-43d5-8ec9-f9e02cac4636.root --fileout file:step2.root --nThreads 4

runs in CMSSW_17_0_ASAN_X_2026-05-06-2300.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50898/49253

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

• RecoTracker/PixelSeeding (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @gpetruc, @mmasciov, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50898/49254

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50898/49254/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50898/49254/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50898/49255

[cmsbuild]

Pull request #50898 was updated. @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

[AdrianoDee]

enable gpu

[AdrianoDee]

please test for CMSSW_17_0_ASAN_X

[smuzaffar]

please test workflow 34634.114 for CMSSW_17_0_UBSAN_X

[smuzaffar]

please test

lets run default tests too

[smuzaffar]

please test workflow 34634.114 with #50882 for CMSSW_17_0_UBSAN_X

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b17025/53117/summary.html
COMMIT: bcd7aaf
CMSSW: CMSSW_17_0_X_2026-05-07-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50898/53117/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 55
• DQMHistoTests: Total histograms compared: 4420967
• DQMHistoTests: Total failures: 26
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4420921
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
• Checked 235 log files, 207 edm output root files, 55 DQM output files
• TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

• You potentially added 9 lines to the logs
• Reco comparison results: 363 differences found in the comparisons
• DQMHistoTests: Total files compared: 13
• DQMHistoTests: Total histograms compared: 216259
• DQMHistoTests: Total failures: 31372
• DQMHistoTests: Total nulls: 37
• DQMHistoTests: Total successes: 184850
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 12 files compared)
• Checked 49 log files, 50 edm output root files, 13 DQM output files
• TriggerResults: found differences in 1 / 12 workflows

AMD_W7900 Comparison Summary

There are some workflows for which there are errors in the baseline:
34634.751 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 76 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 372 differences found in the comparisons
• DQMHistoTests: Total files compared: 12
• DQMHistoTests: Total histograms compared: 184046
• DQMHistoTests: Total failures: 26074
• DQMHistoTests: Total nulls: 13
• DQMHistoTests: Total successes: 157959
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
• Checked 48 log files, 50 edm output root files, 12 DQM output files
• TriggerResults: found differences in 1 / 11 workflows

NVIDIA_H100 Comparison Summary

Summary:

• You potentially removed 27 lines from the logs
• Reco comparison results: 357 differences found in the comparisons
• DQMHistoTests: Total files compared: 13
• DQMHistoTests: Total histograms compared: 216259
• DQMHistoTests: Total failures: 28273
• DQMHistoTests: Total nulls: 32
• DQMHistoTests: Total successes: 187954
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 12 files compared)
• Checked 49 log files, 50 edm output root files, 13 DQM output files
• TriggerResults: found differences in 3 / 12 workflows

NVIDIA_L40S Comparison Summary

Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 349 differences found in the comparisons
• DQMHistoTests: Total files compared: 13
• DQMHistoTests: Total histograms compared: 216259
• DQMHistoTests: Total failures: 30218
• DQMHistoTests: Total nulls: 32
• DQMHistoTests: Total successes: 186009
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 12 files compared)
• Checked 49 log files, 50 edm output root files, 13 DQM output files
• TriggerResults: found differences in 1 / 12 workflows

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b17025/53120/summary.html
COMMIT: bcd7aaf
CMSSW: CMSSW_17_0_UBSAN_X_2026-05-06-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50898/53120/install.sh to create a dev area with all the needed externals and cmssw changes.

[jfernan2]

The ASAN tests seem somehow to be stuck or do you think we should wait a bit longer @smuzaffar ? Thank you

[AdrianoDee]

type bug-fix

[smuzaffar]

The ASAN tests seem somehow to be stuck or do you think we should wait a bit longer @smuzaffar ? Thank you

I have restarted the ASAN relval job but this PR has fixed the issue we have seen in the UBSAN IBs. https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b17025/53120/runTheMatrix-results/34634.114_TTbar_14TeV+Run4D121PU_OTInefficiency10PC/step2_TTbar_14TeV+Run4D121PU_OTInefficiency10PC.log does not show the run time error any more. So feel free to sign it

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #50882

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b17025/53114/summary.html
COMMIT: bcd7aaf
CMSSW: CMSSW_17_0_ASAN_X_2026-05-06-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50898/53114/install.sh to create a dev area with all the needed externals and cmssw changes.

[mandrenguyen]

+1