UBSAN: For NanoAOD, added DataFormats/RPCRecHit dependency to avoid link error

[smuzaffar]

This PR proposes to explicitly add DataFormats/RPCRecHit dependency for PhysicsTools/NanoAOD/plugins to fix the linking error for UBSAN IBs

  bin/ld.bfd: tmp/el8_amd64_gcc13/src/PhysicsTools/NanoAOD/plugins/PhysicsToolsNanoAODPlugins/dtMDSshowerTableProducer.cc.o:(.data.rel+0xc58): undefined reference to `typeinfo for RPCRecHit'

RPCRecHit is needed due to RPCRecHitCollection used by following in this plugin

./cscMDSshowerTableProducer.cc:#include "DataFormats/RPCRecHit/interface/RPCRecHitCollection.h"
./cscMDSshowerTableProducer.cc:        rpchitToken_(consumes<RPCRecHitCollection>(iConfig.getParameter<edm::InputTag>("rpcLabel"))),
./cscMDSshowerTableProducer.cc:  edm::EDGetTokenT<RPCRecHitCollection> rpchitToken_;
./dtMDSshowerTableProducer.cc:#include "DataFormats/RPCRecHit/interface/RPCRecHitCollection.h"
./dtMDSshowerTableProducer.cc:        rpchitToken_(consumes<RPCRecHitCollection>(iConfig.getParameter<edm::InputTag>("rpcLabel"))),
./dtMDSshowerTableProducer.cc:  edm::EDGetTokenT<RPCRecHitCollection> rpchitToken_;

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50882/49235

[cmsbuild]

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@battibass, @ftorrresd can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please build for CMSSW_17_0_UBSAN_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4e7c2/53080/summary.html
COMMIT: 6fcdccc
CMSSW: CMSSW_17_0_UBSAN_X_2026-05-04-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50882/53080/install.sh to create a dev area with all the needed externals and cmssw changes.

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4e7c2/53079/summary.html
COMMIT: 6fcdccc
CMSSW: CMSSW_17_0_X_2026-05-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50882/53079/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 53
• DQMHistoTests: Total histograms compared: 4187168
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4187136
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
• Checked 227 log files, 197 edm output root files, 53 DQM output files
• TriggerResults: no differences found

[cmsbuild]

REMINDER @sextonkennedy, @ftenchini, @mandrenguyen: This PR was tested with #50883, please check if they should be merged together

[smuzaffar]

@cms-sw/xpog-l2 can you please review this trivial fix ?

[cmsbuild]

REMINDER @mandrenguyen, @ftenchini, @sextonkennedy: This PR was tested with #50898, please check if they should be merged together

[smuzaffar]

@cms-sw/orp-l2 , can you please merge this. This is a technical change to fix the UBSAN build errors

[ftorrresd]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1