Skip to content

Embedding hep mc filter fix for photos#50894

Closed
alebihan wants to merge 269 commits into
cms-sw:masterfrom
alebihan:EmbeddingHepMCFilter_fix_forphotos
Closed

Embedding hep mc filter fix for photos#50894
alebihan wants to merge 269 commits into
cms-sw:masterfrom
alebihan:EmbeddingHepMCFilter_fix_forphotos

Conversation

@alebihan
Copy link
Copy Markdown

@alebihan alebihan commented May 6, 2026 •
edited
Loading

PR description:

Two protections added to avoid crashed when using photos ("null vertices of intermediate 746 particles")

PR validation:

Tested on 10k events

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is made to the master branch to be backported to 140X releases to produce a 2024 sample for the dedicated DY production needed for tau polarisation studies

cmsbuild and others added 30 commits September 18, 2025 16:28
@cmsbuild
Merge pull request cms-sw#48942 from mmusich/mm_dev_trim_down_alcapro…
b88c853 
…mpt_15_1_X

[15.1.X] Trim down `ALCAPROMPT` step in the Prompt Calibration Loop
@cmsbuild
Merge pull request cms-sw#48892 from nancymarinelli/patch-2
6dec3e6 
[15_1_X] Bug fixing in the RecoEgamma/plugins/PhotonValidator.cc
Correct the material contetof the steel cover in the CE-H section
666aaee
HI GEN rnd issue: b/p of cms-sw#48906 to CMSSW_15_1_X
9fb30cb
@cmsbuild
Merge pull request cms-sw#48956 from bsunanda/Phase2-hgx364C
882d7ac 
Phase2-364C: Correct the material contet of the steel cover in the CE-H section
@mmusich
add support for multiple input FEDs in HLTL1NumberFilter
10effed
@waredjeb
add GPU-CPU difference plots
1a41684
@hjbossi
[DQM]: Changes to ZDC DQM.
0315feb
@hjbossi
Fix code format
a19ff6d
@waredjeb
use deltaPhi
012cb95
@hjbossi
Change naming convention to match request from FSC team.
4b5a2ad
@mmusich
deal with Fake HLT menus in ScoutingMuonTriggerAnalyzer
96fa56f
@mmusich
fix typos in ScoutingMuonTriggerAnalyzer
0a0c52c
@cmsbuild
Merge pull request cms-sw#48946 from mmusich/mm_HGCalHLTValidation
4c67b37 
[15.1.X] Further fixes for HGCal validation at HLT
@cmsbuild
Merge pull request cms-sw#48965 from cms-tsg-storm/dev_support_second…
a388a29 
…aryTCDS_15_1_X

[15.1.X] add support for multiple input FEDs in `HLTL1NumberFilter`
@kmorrison314
EMTF DQM Plot Fixes for backport
4b7131a
@hjbossi
Add emulated vs. unpacked info.
f003106
@cmsbuild
Merge pull request cms-sw#48993 from mmusich/mm_dealWithFakeHLTMenuSc…
d8e20f4 
…outingMuonTriggerAnalyzer_15_1_X

[15.1.X] deal with `Fake` HLT menus in `ScoutingMuonTriggerAnalyzer`
Update the ZDC description using a new zdc.xml file from Hanna - back…
c379cbb 
…port of cms-sw#48990
@mmusich
add HLT vertexing resolution monitoring (by split vertex method)
dbd2ab7
@mmusich
PrimaryVertexResolution: add protection against missing track referen…
b27b0bd 
…ces in input vertex
@hjbossi
Binning changes and additional comment from HCAL review.
5ee436a
@AdrianoDee
Properly clamping n hits
edbd83f
@konpas17
[15.1.X] HCAL: Move HF fine-grain thresholds to conditions
0a95ffc
@cmsbuild
Merge pull request cms-sw#48910 from cericeci/15_1_X_suepfix
818822c 
[15_1_X] Fixed pz transform for SUEP constituent
@cmsbuild
Merge pull request cms-sw#48973 from waredjeb/pfDQM_diff_plots_15_1_X
d178ab7 
[15_1_X]  Add PF GPU-CPU difference plots in DQM
@cmsbuild
Merge pull request cms-sw#48948 from fwyzard/update_warpsize_for_ROCm…
c53c98c 
…_7.0

Update the compile-time warp size constant for ROCm 7.0 [15.1.x]
@cmsbuild
Merge pull request cms-sw#48977 from hjbossi/ZDCDQMUpdates
ff643f8 
[15_1_X_DQM]: Changes to ZDC DQM for HIN Data-Taking 2025.
@cmsbuild
Merge pull request cms-sw#49002 from bsunanda/Run3-gex190X
b53ffc8 
[15_1_X] Run3-gex190X Update the ZDC description using a new zdc.xml file from Hanna - backport of cms-sw#48990
@cmsbuild
Merge pull request cms-sw#49008 from missirol/devel_l1tZDCEtSumsEmul
91c25e5 
fix emulation of L1T ZDC EtSums [`15_1_X`]
Samuel Bein and others added 18 commits March 6, 2026 17:42
@sbein
making FastSim refinement default for Run 2 CHS jets should this ever…
5fa6e84 
… be needed and Run 3 (PUPPI jets)
@sbein
updated onnx file name
fc1cebe
@sbein
updated file name to match cms-data
8259a0b
@sbein
updated weight file name after removing data file from history
d421904
@sbein
Fix refinement module by rebinding refined variables as userFloats to…
1fc88a9 
… standard jet variables (validated)
@sbein
implemented mask that sets occasional unrefined values as the default…
5973d41 
…, but it misses -1 safety
@sbein
introduced max(x,-1) function in lieu of ?x>0?x:-1, which restores th…
9c225a1 
…e other negative DeepJet and UParT tagger values (all less than -1) without breaking the parser
@sbein
updated warning comment to make it more chill
30fb108
@kpedro88 @sbein
apply CHS refinement only if DeepFlavour is available
d781596
@kpedro88 @sbein
Revert "add test 2016 workflow for fastsim refinement"
5e26311 
This reverts commit 565306c.
@sbein
implemented refined pT-based sorting of jets in NANO, Type-1 MET corr…
dc65e85 
…ection of the refined jets
@sbein
add forgotten fastSim modifier
1cfc820
@sbein
made requested formatting changes
d092a8a
@sbein
scram b code-format
a61c5a6
@cmsbuild
Merge pull request cms-sw#50324 from perrotta/synchro2026Gt_151X
70e5869 
Update 2025 MC GT in autoCond - CMSSW_15_1_X
@cmsbuild
Merge pull request cms-sw#50328 from makortel/siPixelDigitizerAlgorit…
992e7eb 
…hmInit_151x

[15_1_X] Speed up SiPixelDigitizerAlgorithm::init()
@cmsbuild
Merge pull request cms-sw#50334 from sbein/fastsim-jet-refine-backpor…
1171b12 
…t-151x

Fastsim jet refine backport 151x
@alebihan
Protections to avoid crashes with photos
abeb864
@cmsbuild cmsbuild added this to the CMSSW_17_0_X milestone May 6, 2026
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 6, 2026

This PR contains too many commits (269 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

@AdrianoDee
Copy link
Copy Markdown
Contributor

AdrianoDee commented May 7, 2026

@alebihan I suspect you based your development on a 15_1_X branch?

@alebihan
Copy link
Copy Markdown
Author

alebihan commented May 7, 2026

yes exactly, sorry :-(. What would be the best procedure to install the CMSSW's master?

@AdrianoDee
Copy link
Copy Markdown
Contributor

AdrianoDee commented May 7, 2026 •
edited
Loading

An easy way would be to take one of the latest IBs (such as CMSSW_17_0_X_2026-05-06-2300) and use that as the starting point. It's not guaranteed to be identical to the master branch, but it's usually very, very similar to it, and it's already built and ready to use.

This was referenced May 7, 2026
Merged
Merged
Merged
Merged
Open
@alebihan
Copy link
Copy Markdown
Author

alebihan commented May 11, 2026

Thanks for the feedback! have created a new PR from a recent release: #50915

@alebihan alebihan closed this May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

CMSSW_17_0_X

Development

Successfully merging this pull request may close these issues.