Skip to content

[L1T] EMTF DQM Plot Changes to Address CSC Timing Issues#50903

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
kmorrison314:EMTF_DQM_CSCTimingFix_5_7_26
May 12, 2026
Merged

[L1T] EMTF DQM Plot Changes to Address CSC Timing Issues#50903
cmsbuild merged 1 commit into
cms-sw:masterfrom
kmorrison314:EMTF_DQM_CSCTimingFix_5_7_26

Conversation

@kmorrison314
Copy link
Copy Markdown
Contributor

PR description:

The proposed changes effect the cscLCTTiming Plots in the EMTF DQM and work to address poor resolution seen in the CSC chambers in the negative endcap, documented here.

An EMTF investigation revealed that EMTF tracks built with more than or equal to 2 RPC hits contributed significantly to the csc chamber occupancy in BX -1 for the negative endcap region which is not mirrored in the positive endcap region. The source of this problem is a known retriggering issue in RPC chambers in negative endcap. The fix implemented in the PR is to remove tracks with more than or equal to 2 RPC hits from the cscLCTTiming monitoring plots which are used to extract CSC Timing shifts

PR validation:

In order to validate this reason, the BX-1 csc chamber occupancy was plotted for tracks with more than or equal to 2 RPC hits and showed that the occupancy only existed in the negative endcap for a total of 100,000 events (See image below).

Screenshot 2026-05-04 at 4 34 50 PM.

To further validate the fix, the DQM was run over 153,000 events and included cscLCTTiming plots with and without the 2 RPC hit tracks. Through this it is shown that there is an improvement in the csc chamber occupancy in BX-1 and thus the timing resolution (See below).

Before Fix
Screenshot 2026-05-04 at 4 36 53 PM

After Fix
Screenshot 2026-05-07 at 4 49 33 PM.

All standard code checks were done following the CMS Offline Software guidelines

@cmsbuild cmsbuild changed the base branch from CMSSW_17_0_X to master May 7, 2026 14:51
@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 7, 2026

@kmorrison314, CMSSW_17_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 7, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 7, 2026

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50903/49259

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 7, 2026

A new Pull Request was created by @kmorrison314 for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@gabrielmscampos
Copy link
Copy Markdown
Member

gabrielmscampos commented May 7, 2026

test parameters:

  • addpkg = DQM/Integration

@gabrielmscampos
Copy link
Copy Markdown
Member

please test

@gabrielmscampos
Copy link
Copy Markdown
Member

please abort

@gabrielmscampos
Copy link
Copy Markdown
Member

please test

  • now with the test parameters, just in case this touches online

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 8, 2026

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31eab5/53133/summary.html
COMMIT: 6b26911
CMSSW: CMSSW_17_0_X_2026-05-07-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50903/53133/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4187168
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4187119
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@gabrielmscampos
Copy link
Copy Markdown
Member

+dqm

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants