Skip to content

Improve handling of missing/invalid inputs in TrackingAssocValueMapsProducer #50730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Apr 18, 2026
Merged

Improve handling of missing/invalid inputs in TrackingAssocValueMapsProducer #50730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions PhysicsTools/NanoAOD/plugins/TrackingAssocValueMapsProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ TrackingAssocValueMapsProducer::TrackingAssocValueMapsProducer(const edm::Parame
}

void TrackingAssocValueMapsProducer::produce(edm::Event& iEvent, const edm::EventSetup&) {
const std::string metname = "PhysicsTools/NanoAOD/TrackingAssocValueMapsProducer";

edm::Handle<edm::View<reco::Track>> tracksH;
iEvent.getByToken(tracksToken_, tracksH);

Expand All @@ -145,19 +147,10 @@ void TrackingAssocValueMapsProducer::produce(edm::Event& iEvent, const edm::Even

const size_t nTracks = tracksH->size();

if (nTracks == 0 || !inputsValid) {
// No tracks or invalid handles, put empty ValueMaps and return
iEvent.put(std::make_unique<edm::ValueMap<int>>(), "matched");
iEvent.put(std::make_unique<edm::ValueMap<int>>(), "duplicate");
iEvent.put(std::make_unique<edm::ValueMap<int>>(), "tpPdgId");
iEvent.put(std::make_unique<edm::ValueMap<int>>(), "tpCharge");
if (storeTPKinematics_) {
iEvent.put(std::make_unique<edm::ValueMap<float>>(), "tpPt");
iEvent.put(std::make_unique<edm::ValueMap<float>>(), "tpEta");
iEvent.put(std::make_unique<edm::ValueMap<float>>(), "tpPhi");
}
return;
}
LogDebug(metname) << "Retrieved " << nTracks << " tracks and " << tpH->size()
<< " tracking particles. Track handle valid: " << tracksH.isValid()
<< ", TP handle valid: " << tpH.isValid() << ", associator handle valid: "
<< (useMuonAssociators_ ? recoToSimH.isValid() && simToRecoH.isValid() : associatorH.isValid());

std::vector<int> matched(nTracks, 0);
std::vector<int> duplicate(nTracks, 0);
Expand All @@ -171,6 +164,21 @@ void TrackingAssocValueMapsProducer::produce(edm::Event& iEvent, const edm::Even
tpPhi.assign(nTracks, -10.f);
}

if (nTracks == 0 || !inputsValid) {
LogDebug(metname) << "No tracks or invalid inputs, producing empty ValueMaps.";
// No tracks or invalid handles, put ValueMaps with default values and return
fillAndPut<int>(iEvent, tracksH, std::make_unique<edm::ValueMap<int>>(), matched, "matched");
fillAndPut<int>(iEvent, tracksH, std::make_unique<edm::ValueMap<int>>(), duplicate, "duplicate");
fillAndPut<int>(iEvent, tracksH, std::make_unique<edm::ValueMap<int>>(), tpPdgId, "tpPdgId");
fillAndPut<int>(iEvent, tracksH, std::make_unique<edm::ValueMap<int>>(), tpCharge, "tpCharge");
if (storeTPKinematics_) {
fillAndPut<float>(iEvent, tracksH, std::make_unique<edm::ValueMap<float>>(), tpPt, "tpPt");
fillAndPut<float>(iEvent, tracksH, std::make_unique<edm::ValueMap<float>>(), tpEta, "tpEta");
fillAndPut<float>(iEvent, tracksH, std::make_unique<edm::ValueMap<float>>(), tpPhi, "tpPhi");
}
return;
}

edm::RefToBaseVector<reco::Track> trackRefs;
for (edm::View<reco::Track>::size_type i = 0; i < nTracks; ++i) {
trackRefs.push_back(tracksH->refAt(i));
Expand Down