Skip to content

Add Phase 2 HLT CPU vs. GPU wf to the ph2_hlt PR tests#50505

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
SegmentLinking:addHLTCPUvsGPUinph2_hlt
May 12, 2026
Merged

Add Phase 2 HLT CPU vs. GPU wf to the ph2_hlt PR tests#50505
cmsbuild merged 1 commit into
cms-sw:masterfrom
SegmentLinking:addHLTCPUvsGPUinph2_hlt

Conversation

@VourMa
Copy link
Copy Markdown
Contributor

@VourMa VourMa commented Mar 24, 2026

Small follow up to #50336, adding the Phase 2 HLT CPU vs. GPU workflow to the list of ph2_hlt PR tests. To be tested during PR tests.

This PR can also be used to test cms-sw/cms-bot#2710.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Mar 24, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50505/48673

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @VourMa for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @miquork can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

'ph2_hlt' : [prefixDet+34.75, # HLT phase-2 timing menu
prefixDet+34.7501, # HLT phase-2 tracking-only menu
prefixDet+34.7502, # HLT phase-2 tracking menu with tracking ntuple
prefixDet+34.7503, # HLT phase-2 menu, CPU vs. GPU validation
Copy link
Copy Markdown
Contributor

@mmusich mmusich Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this change is appropriate, in general we don't run these tests with the "gpu" enabled.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there are quite a few cases where it happens that we run the ph2_hlt tests with GPUs enabled, so this is targeting those cases as an extra tests. However, I agree it is situational.

If you think this is unnecessary, I will close the PR. Let me know.

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 24, 2026

test parameters:

  • workflow = ph2_hlt

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented Mar 24, 2026

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-685dbe/52180/summary.html
COMMIT: 8b5534b
CMSSW: CMSSW_16_1_X_2026-03-24-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50505/52180/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Apr 4, 2026

Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X.

@antoniovagnerini
Copy link
Copy Markdown

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-685dbe/52883/summary.html
COMMIT: 8b5534b
CMSSW: CMSSW_17_0_X_2026-04-26-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50505/52883/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

  • 2023.00200012023.0020001_RunJetMET02023D_10k/step1_dasquery.log
  • 2022.00100012022.0010001_RunTau2022D_10k/step1_dasquery.log
  • 2025.00000022025.0000002_RunZeroBias2025B_10k/step1_dasquery.log
Expand to see more relval errors ...

@mmusich
Copy link
Copy Markdown
Contributor

mmusich commented May 7, 2026

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented May 8, 2026

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-685dbe/53110/summary.html
COMMIT: 8b5534b
CMSSW: CMSSW_17_0_X_2026-05-06-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50505/53110/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 66
  • DQMHistoTests: Total histograms compared: 4569622
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4569593
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 65 files compared)
  • Checked 276 log files, 236 edm output root files, 66 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link
Copy Markdown

+pdmv

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants