Skip to content

Cleanup CUDACore dependency from PFClusterProducer/plugin#50046

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:cleanup-CUDACore-dep
Feb 11, 2026
Merged

Cleanup CUDACore dependency from PFClusterProducer/plugin#50046
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:cleanup-CUDACore-dep

Conversation

@smuzaffar
Copy link
Copy Markdown
Contributor

#49891 removed the legacy cuda framework and HeterogeneousCore/CUDACore does not generate any public shared library. This PR removes the HeterogeneousCore/CUDACore dependency from RecoParticleFlow/PFClusterProducer/plugins`.

This should fix the scram's warning

****WARNING: Invalid tool HeterogeneousCore/CUDACore. Please fix src/RecoParticleFlow/PFClusterProducer/plugins/BuildFile.xml file.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 5, 2026

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 5, 2026

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 5, 2026

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • RecoParticleFlow/PFClusterProducer (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@felicepantaleo, @hatakeyamak, @lgray, @mmarionncern, @rovere, @sameasy, @seemasharmafnal this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Feb 5, 2026

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a4353/51135/summary.html
COMMIT: d2f55b6
CMSSW: CMSSW_16_1_X_2026-02-05-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50046/51135/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Copy Markdown
Contributor Author

@cms-sw/reconstruction-l2 can you please review this. This PR just contains a trivial cleanup of Buildfile

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Feb 11, 2026

+1

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@Moanwar
Copy link
Copy Markdown
Contributor

Moanwar commented Feb 11, 2026

@cms-sw/reconstruction-l2 can you please review this. This PR just contains a trivial cleanup of Buildfile

Sorry for late, I may just missed it, thanks!

@mandrenguyen
Copy link
Copy Markdown
Contributor

+1

@cmsbuild cmsbuild merged commit 14e34f9 into cms-sw:master Feb 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants