[EVO] Moved stored products in l1t:: to versioned namespace by Dr15Jones · Pull Request #50075 · cms-sw/cmssw

Dr15Jones · 2026-02-09T21:12:46Z

PR description:

Part of the versioned namespace migration.

PR validation:

Code compiles.

resolves cms-sw/framework-team#1873

cmsbuild · 2026-02-09T21:13:15Z

cms-bot internal usage

Dr15Jones · 2026-02-09T21:13:57Z

type evolution

cmsbuild · 2026-02-09T21:14:42Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50075/47960

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50075/47960/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50075/47960/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-02-09T21:42:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50075/47979

cmsbuild · 2026-02-09T21:43:25Z

A new Pull Request was created by @Dr15Jones for CMSSW_16_1_EVOLUTION_X.

It involves the following packages:

DataFormats/L1TCalorimeter (l1)
DataFormats/L1TCorrelator (l1)
DataFormats/L1THGCal (l1)
DataFormats/L1TMuon (l1)
DataFormats/L1TMuonPhase2 (l1)
DataFormats/L1TParticleFlow (l1)
DataFormats/L1Trigger (l1)
L1Trigger/L1THGCalUtilities (l1)
L1Trigger/L1TMuonOverlap (l1)
L1Trigger/L1TMuonOverlapPhase1 (l1)
L1Trigger/Phase2L1ParticleFlow (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @dinyar, @eyigitba, @jbsauvan, @lgray, @missirol, @mmusich, @rovere, @thomreis this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2026-02-09T21:43:55Z

please test

Dr15Jones · 2026-02-09T21:44:08Z

assign core

cmsbuild · 2026-02-09T21:44:25Z

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2026-02-09T22:07:10Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f198f3/51197/summary.html
COMMIT: bf651e6
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-02-06-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/50075/51197/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Build

I found compilation error when building:

>> Checking EDM Class Version for src/L1Trigger/VertexFinder/src/classes_def.xml in L1TriggerVertexFinder
@@@@ ----> OK EDM Class Version L1TriggerPhase2L1GT
@@@@ ----> OK EDM Class Version L1TriggerL1THGCalUtilities
>> Checking EDM Class Transients in L1TriggerPhase2L1GT
>> Checking EDM Class Transients in L1TriggerL1THGCalUtilities
error: class 'trigger::TriggerRefsCollections' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1210037489
error: class 'trigger::TriggerFilterObjectWithRefs' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 4124915994
error: class 'trigger::TriggerEventWithRefs' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 307844616
error: class 'L2MuonTrajectorySeed' has a different checksum for ClassVersion 13. Increment ClassVersion to 14 and assign it to checksum 846735298
error: class 'L3MuonTrajectorySeed' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 1398743106
error: class 'reco::IsolatedPixelTrackCandidate' has a different checksum for ClassVersion 3. Increment ClassVersion to 4 and assign it to checksum 412602791

Static analyzer reported errors, please check

cmsbuild · 2026-02-11T19:39:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50075/48039

cmsbuild · 2026-02-11T19:39:52Z

Pull request #50075 was updated. @BenjaminRS, @Dr15Jones, @Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @makortel, @mandrenguyen, @mmusich, @quinnanm, @smuzaffar, @srimanob can you please check and sign again.

Dr15Jones · 2026-02-11T19:39:54Z

please test

cmsbuild · 2026-02-11T22:45:30Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f198f3/51272/summary.html
COMMIT: a081262
CMSSW: CMSSW_16_1_EVOLUTION_X_2026-02-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50075/51272/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f198f3/51272/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f198f3/51272/git-merge-result

Static analyzer reported errors, please check

Failed RelVals

25202.0

----- Begin Fatal Exception 11-Feb-2026 23:17:11 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

2500.3001

----- Begin Fatal Exception 11-Feb-2026 23:27:12 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
No Dictionary for class: 'edm::OwnVector<reco::BaseTagInfo,edm::ClonePolicy<reco::BaseTagInfo> >'
----- End Fatal Exception -------------------------------------------------

312.0

----- Begin Fatal Exception 11-Feb-2026 23:15:18 CET-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  edm::Wrapper<std::vector<reco::GenJet> >
  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<reco::GenJet>
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  std::vector<reco::GenJet> (read from input)
  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  recoGenJets_ak4GenJetsNoNu__SIM.
  recoGenJets_ak4GenJets__SIM.
  recoGenJets_ak8GenJetsNoNu__SIM.
  recoGenJets_ak8GenJets__SIM.
  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

Failed AddOn Tests

pat1

----- Begin Fatal Exception 11-Feb-2026 23:07:13 CET-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664'
   Additional Info:
      [a] Attempted to open logical file /store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root.
      [b] Failed to open file with physical name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback. The error was
Error type FatalRootError
Fatal Root Error: @SUB=TStreamerInfo::BuildCheck

   The StreamerInfo of class reco::Photon::PflowIDVariables read from file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root
   has the same version (=3) as the active class but a different checksum.
   You should update the version to ClassDef(reco::Photon::PflowIDVariables,4).
   Do not try to write objects with the current class definition,
   the files will not be readable.


      [c] Failed to open the file with physical name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664. Will attempt fallback.
      [d] Failed to open the file with physical name root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664.
      [e] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.
' (errno=3011, code=400). No additional data servers were found.
      [f] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root?scitag.flow=196664&tried=+1213xrootd-cms-redir-int.cr.cnaf.infn.it&xrdcl.requuid=3ef06bf3-c813-4334-8ac4-8cdeeae43c0b
      [g] Problematic data server: cms-xrd-global.cern.ch:1094
      [h] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

Dr15Jones · 2026-02-12T14:22:57Z

ignore tests-rejected with manual-override

makortel · 2026-02-12T19:18:33Z

-  <class name="l1t::HGCalTower" />
-  <class name="std::vector<l1t::HGCalTower>" />
-  <class name="std::unordered_map<int,l1t::HGCalTower>" />
+  <class name="l1t::io_v1::HGCalTower" />


This entry should have a class version (but we could add it later).

(to be done later)

makortel · 2026-02-12T19:21:20Z

+core

mandrenguyen · 2026-02-13T06:33:40Z

merge

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Feb 9, 2026

cmsbuild added the evolution label Feb 9, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 9, 2026

Dr15Jones force-pushed the evo_l1t branch from 7ed2b89 to bf651e6 Compare February 9, 2026 21:39

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 9, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 9, 2026

cmsbuild added core-pending tests-started and removed tests-pending labels Feb 9, 2026

cmsbuild added tests-rejected and removed tests-started tests-rejected code-checks-approved labels Feb 9, 2026

cmsbuild added tests-pending code-checks-pending and removed code-checks-approved labels Feb 11, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 11, 2026

cmsbuild added tests-started and removed tests-pending labels Feb 11, 2026

cmsbuild added tests-rejected and removed tests-started labels Feb 11, 2026

cmsbuild added tests-approved tests-manual-override and removed tests-rejected labels Feb 12, 2026

makortel reviewed Feb 12, 2026

View reviewed changes

cmsbuild added core-approved and removed core-pending labels Feb 12, 2026

cmsbuild added orp-approved and removed orp-pending labels Feb 13, 2026

cmsbuild merged commit a2d8853 into cms-sw:CMSSW_16_1_EVOLUTION_X Feb 13, 2026
7 of 9 checks passed

makortel mentioned this pull request Feb 13, 2026

Add class version for l1t::io_v1::HGCalTower cms-sw/framework-team#1907

Closed

Dr15Jones deleted the evo_l1t branch February 13, 2026 14:49

cmsbuild mentioned this pull request Feb 13, 2026

Merge CMSSW_16_1 into EVOLUTION after fixing merge conflict #50132

Merged

This was referenced Feb 24, 2026

[EVO] Fix merge conflict in GsfTracking classes_def.xml #50242

Merged

[EVO] Moved data products in to io_v1 namespace #50230

Merged

Conversation

Dr15Jones commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dr15Jones commented Feb 9, 2026

Uh oh!

cmsbuild commented Feb 9, 2026

Uh oh!

cmsbuild commented Feb 9, 2026

Uh oh!

cmsbuild commented Feb 9, 2026

Uh oh!

Dr15Jones commented Feb 9, 2026

Uh oh!

Dr15Jones commented Feb 9, 2026

Uh oh!

cmsbuild commented Feb 9, 2026

Uh oh!

cmsbuild commented Feb 9, 2026

Failed Build

Uh oh!

cmsbuild commented Feb 11, 2026

Uh oh!

cmsbuild commented Feb 11, 2026

Uh oh!

Dr15Jones commented Feb 11, 2026

Uh oh!

cmsbuild commented Feb 11, 2026

Failed RelVals

Failed AddOn Tests

Uh oh!

Dr15Jones commented Feb 12, 2026

Uh oh!

makortel Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

makortel Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

makortel commented Feb 12, 2026

Uh oh!

mandrenguyen commented Feb 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dr15Jones commented Feb 9, 2026 •

edited

Loading

cmsbuild commented Feb 9, 2026 •

edited

Loading