fix: promote images from :latest so unchanged images get the release version#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
promote-imagesjob retagged each image from:<release-sha>→:<version>. But with affected-only builds, an image that didn't change in the release commit has no:<release-sha>tag, soimagetools createfails for it andset -euo pipefailaborts the whole loop.It only worked for
3.20.0by luck: that release commit touchedtools/ci+ workflows (matchingTOOLING_GLOBS→ build-everything), so all 8 images happened to have the sha. A normal release commit would leave most images un-promoted.Fix: retag from
:latestinstead. Every image always has a:latest(its most-recent main build, changed this cycle or not), so the retag never hits a missing source — and the semantics are better: "version X = the current state of every image at release time." Server-side manifest retag, no rebuild.This is a prerequisite for pinning the compose files to release versions (a follow-up), which depend on every image reliably having its
:<version>tag.🤖 Generated with Claude Code