feat: pin custom images to a deploy version via IMAGE_TAG default#91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploys now run a pinned version of each custom image instead of floating
:latest.How
Each custom-image compose line becomes:
IMAGE_TAGunset) → pulls the pinned:3.20.0default. The version lives literally in the file.:-3.20.0→:-3.21.0) in the compose files and redeploy. Manual and deliberate, like the kenku pin.build.yml,task build/publish) → run withIMAGE_TAG=latest, so the sameimage:line tags/pushes:latest. This decouples the build tag from the deploy pin — otherwisebake --pushwould clobber the released version and stop updating:latest.Why a variable and not a bare
:3.20.0The custom images are both built and deployed from the one compose
image:field (unlike kenku, which is only deployed). A bare literal would make builds push to the pinned tag.${IMAGE_TAG:-<version>}keeps the version literal in the file while letting build tooling override to:latestwith a single env var.Also fixes a parsing bug it exposed
ci imagesparsed image names withrfind(':'), which grabbed the:inside${IMAGE_TAG:-3.20.0}→warden:${IMAGE_TAG. Switched to the first colon after the last/(image names can't contain:). Added a regression test (red/green).Notes
:latest → :version); together they guarantee every release reliably produces the:versiontags these pins depend on. fix: promote images from :latest so unchanged images get the release version #90 should land first.:3.20.0(last release), so this pin is immediately deployable.citooling tests: 28 passing.🤖 Generated with Claude Code