Skip to content

Add Ecowitt GW2000 Gateway profile #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
frenck wants to merge 3 commits into from
Closed

Add Ecowitt GW2000 Gateway profile #3201

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b077973
Add Ecowitt GW2000 Gateway profile
frenck Mar 19, 2025
9585708
chore(lint): [pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 19, 2025
b53b9a1
Update profile_library/ecowitt/GW2000A/model.json
frenck Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions profile_library/ecowitt/GW2000A/model.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"calculation_strategy": "fixed",
"created_at": "2025-03-19T12:03:21",
"device_type": "network",
"fixed_config": {
"power": 1.09
},
"measure_description": "Measured with utils/measure script, average of 20 measurements",
"measure_device": "Shelly PM mini 3Gen",
"measure_method": "script",
"name": "Ecowitt GW2000 Gateway",
"alias": [
"GW2000A"
],
Comment thread
frenck marked this conversation as resolved.
Outdated
"author": "Franck Nijhof <opensource@frenck.dev>"
}
4 changes: 4 additions & 0 deletions profile_library/ecowitt/manufacturer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"name": "Ecowitt",
Copy link
Copy Markdown
Owner

@bramstroker bramstroker Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Ecowitt",
"name": "ecowitt",

Manufacturer has to be lowercased, pretty sure it causes issues with discovery otherwise. Need to have a look into that, but just to be sure let's keep it lowercase for now.

Copy link
Copy Markdown
Contributor Author

@frenck frenck Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this would be mixing up the logo branding from the writing. In writing, they capitalize; in their logo, it is lowercase. Many brands have that distinction actually.

Making this lower case would convey an incorrect or misrepresentation of the brand, and I would strongly oppose it; mostly because this is often in conflict with official upstream branding guidelines.

../Frenck

Copy link
Copy Markdown
Owner

@bramstroker bramstroker Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck Thanks for raising your concerns. I agree it would be nicer if we could use proper cased brand/manufacturer name here, however currently it will cause problems with model not being found/downloaded correctly.
See for example this issue: #2619.
It's a known issue and I need to get around to fix it, but just didn't find the time to do so, and I considered it a low priority issue.
There are numerous places which needs to be checked/refactored and tested so it's unfortunately not a single one liner fixed.

And probably more places. Needs thorough testing as I don't want to brick users installations and must ensure BC compatibility with older versions of the integration.

There are two spots these manufacturers are user facing. In the library website.

Screenshot 2025-03-19 at 19 54 31

When setting up config entry when choosing Virtual power (library)

Screenshot 2025-03-19 at 19 55 41

I'll create an issue so it's on my backlog.

P.S. for consistency also all other manufacturers needs to be fixed for the right casing after it is fixed.

"aliases": []
}
Loading