Skip to content

Add Ecowitt GW2000 Gateway profile#3201

Closed
frenck wants to merge 3 commits intobramstroker:masterfrom
frenck:frenck-2025-0131
Closed

Add Ecowitt GW2000 Gateway profile#3201
frenck wants to merge 3 commits intobramstroker:masterfrom
frenck:frenck-2025-0131

Conversation

@frenck
Copy link
Copy Markdown
Contributor

@frenck frenck commented Mar 19, 2025

Device information

The Ecowitt GW2000 Gateway

image

Ecowitt: https://www.ecowitt.com/shop/goodsDetail/178
Amazon: https://amzn.to/4iTTyGC

Home Assistant Device information

CleanShot 2025-03-19 at 13 13 58

GW2000A
Firmware: 132

Checklist

  • I have created a single PR per device. When you have multiple submissions please create separate PR's.
  • For lights - I have only included the gzipped files (*.gz), not the raw CSV files.
  • For lights - I have provided a CSV file per supported color mode. Look that up in Developer Tools -> States

Additional info

@frenck
Copy link
Copy Markdown
Contributor Author

frenck commented Mar 19, 2025

I've used the device type: network, but it is a gateway for weather sensors. It seemed like the best-fitting device category, but I'm also not 100% sure.

@bramstroker
Copy link
Copy Markdown
Owner

I've used the device type: network, but it is a gateway for weather sensors. It seemed like the best-fitting device category, but I'm also not 100% sure.

Yes network is fine.
It's only used for categorisation on library website: https://library.powercalc.nl/. It has no further function in code.

@frenck
Copy link
Copy Markdown
Contributor Author

frenck commented Mar 19, 2025

Alright, thanks! 👍

Copy link
Copy Markdown
Owner

@bramstroker bramstroker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed I forgot to submit review points / suggestions.
Not the first times that happens to me ;-)

Comment thread profile_library/ecowitt/GW2000A/model.json Outdated
@@ -0,0 +1,4 @@
{
"name": "Ecowitt",
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Ecowitt",
"name": "ecowitt",

Manufacturer has to be lowercased, pretty sure it causes issues with discovery otherwise. Need to have a look into that, but just to be sure let's keep it lowercase for now.

Copy link
Copy Markdown
Contributor Author

@frenck frenck Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this would be mixing up the logo branding from the writing. In writing, they capitalize; in their logo, it is lowercase. Many brands have that distinction actually.

Making this lower case would convey an incorrect or misrepresentation of the brand, and I would strongly oppose it; mostly because this is often in conflict with official upstream branding guidelines.

../Frenck

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frenck Thanks for raising your concerns. I agree it would be nicer if we could use proper cased brand/manufacturer name here, however currently it will cause problems with model not being found/downloaded correctly.
See for example this issue: #2619.
It's a known issue and I need to get around to fix it, but just didn't find the time to do so, and I considered it a low priority issue.
There are numerous places which needs to be checked/refactored and tested so it's unfortunately not a single one liner fixed.

And probably more places. Needs thorough testing as I don't want to brick users installations and must ensure BC compatibility with older versions of the integration.

There are two spots these manufacturers are user facing. In the library website.

Screenshot 2025-03-19 at 19 54 31

When setting up config entry when choosing Virtual power (library)

Screenshot 2025-03-19 at 19 55 41

I'll create an issue so it's on my backlog.

P.S. for consistency also all other manufacturers needs to be fixed for the right casing after it is fixed.

Co-authored-by: Bram Gerritsen <bgerritsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants