Add Ecowitt GW2000 Gateway profile#3201
Conversation
for more information, see https://pre-commit.ci
|
I've used the device type: |
Yes network is fine. |
|
Alright, thanks! 👍 |
bramstroker
left a comment
There was a problem hiding this comment.
just noticed I forgot to submit review points / suggestions.
Not the first times that happens to me ;-)
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "name": "Ecowitt", | |||
There was a problem hiding this comment.
| "name": "Ecowitt", | |
| "name": "ecowitt", |
Manufacturer has to be lowercased, pretty sure it causes issues with discovery otherwise. Need to have a look into that, but just to be sure let's keep it lowercase for now.
There was a problem hiding this comment.
Nope, this would be mixing up the logo branding from the writing. In writing, they capitalize; in their logo, it is lowercase. Many brands have that distinction actually.
Making this lower case would convey an incorrect or misrepresentation of the brand, and I would strongly oppose it; mostly because this is often in conflict with official upstream branding guidelines.
../Frenck
There was a problem hiding this comment.
@frenck Thanks for raising your concerns. I agree it would be nicer if we could use proper cased brand/manufacturer name here, however currently it will cause problems with model not being found/downloaded correctly.
See for example this issue: #2619.
It's a known issue and I need to get around to fix it, but just didn't find the time to do so, and I considered it a low priority issue.
There are numerous places which needs to be checked/refactored and tested so it's unfortunately not a single one liner fixed.
- Stitched API library json at https://api.powercalc.nl/library and script where this is generated: https://github.com/bramstroker/homeassistant-powercalc/blob/master/.github/scripts/profile_library/update-library.py#L26
- API which retrieves the download links for LUT files: https://api.powercalc.nl/download/elgato/Elgato%20Light%20Strip%20Pro. Code for that is here: https://github.com/bramstroker/homeassistant-powercalc/blob/master/utils/library_downloader/src/index.ts
- Lookup and retrieval logic for profiles here: https://github.com/bramstroker/homeassistant-powercalc/blob/master/custom_components/powercalc/power_profile/loader/remote.py
And probably more places. Needs thorough testing as I don't want to brick users installations and must ensure BC compatibility with older versions of the integration.
There are two spots these manufacturers are user facing. In the library website.
When setting up config entry when choosing Virtual power (library)
I'll create an issue so it's on my backlog.
P.S. for consistency also all other manufacturers needs to be fixed for the right casing after it is fixed.
Co-authored-by: Bram Gerritsen <bgerritsen@gmail.com>
Device information
The Ecowitt GW2000 Gateway
Ecowitt: https://www.ecowitt.com/shop/goodsDetail/178
Amazon: https://amzn.to/4iTTyGC
Home Assistant Device information
GW2000A
Firmware: 132
Checklist
Additional info