Skip to content

Generalise TemporaryRenderEntity over AppLabel#24419

Merged
alice-i-cecile merged 3 commits into
bevyengine:mainfrom
Zeophlite:extract-extract4a
Jun 2, 2026
Merged

Generalise TemporaryRenderEntity over AppLabel#24419
alice-i-cecile merged 3 commits into
bevyengine:mainfrom
Zeophlite:extract-extract4a

Conversation

@Zeophlite

@Zeophlite Zeophlite commented May 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Objective

Solution

  • Replace TemporaryRenderEntity with a generic over AppLabel, TemporaryRenderEntity becomes an alias over RenderApp

Testing

  • CI
  • cargo run --example animated_mesh

@Zeophlite Zeophlite force-pushed the extract-extract4a branch from c0d0022 to db237eb Compare May 24, 2026 09:44
@Zeophlite Zeophlite changed the title TemporaryRenderEntity is a RenderApp specific Generalise TemporaryRenderEntity over AppLabel ( RenderApp in particular) May 24, 2026
@Zeophlite Zeophlite changed the title Generalise TemporaryRenderEntity over AppLabel ( RenderApp in particular) Generalise TemporaryRenderEntity over AppLabel May 24, 2026
@Zeophlite Zeophlite force-pushed the extract-extract4a branch from db237eb to 1c6fcc0 Compare May 24, 2026 12:56
@Zeophlite Zeophlite added A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels May 24, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering May 24, 2026
@Zeophlite Zeophlite added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels May 24, 2026
@Zeophlite Zeophlite marked this pull request as ready for review May 24, 2026 14:19
@Zeophlite Zeophlite requested a review from atlv24 May 24, 2026 14:19
@Zeophlite Zeophlite mentioned this pull request May 24, 2026
Open
@Zeophlite Zeophlite added this to the 0.20 milestone May 24, 2026
kfc35
kfc35 approved these changes May 24, 2026
View reviewed changes
Comment thread crates/bevy_render/src/sync_world.rs Outdated
Comment thread crates/bevy_render/src/sync_world.rs Outdated
Comment thread crates/bevy_render/src/extract_plugin.rs Outdated
@Zeophlite Zeophlite mentioned this pull request May 29, 2026
Open
@Zeophlite Zeophlite added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label May 29, 2026
@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 31, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 2, 2026
Merged via the queue into bevyengine:main with commit 0a57f42 Jun 2, 2026
42 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@kfc35 kfc35 kfc35 approved these changes
@atlv24 atlv24 atlv24 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.20

Development

Successfully merging this pull request may close these issues.

4 participants

@Zeophlite @kfc35 @atlv24 @alice-i-cecile