Make ExtractComponentPlugin etc. generic on AppLabel#24423
Open
Zeophlite wants to merge 16 commits into
Open
Conversation
Contributor
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
cd00ee2 to
cebeed8
Compare
ExtractComponentPlugin etc. to specify AppLabel
ExtractComponentPlugin etc. to specify AppLabelExtractComponentPlugin etc. generic on AppLabel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
RenderAppsub-appbevy_extracttracking #24483 )Solution
RenderAppforSyncComponent/ExtractComponent/ExtractResource#24420AppLabel#23377bevy_extract#22852Reviewer notes: changes for this PR are listed below. Other commits are pre-requisties in the preceeding PRs. Please review commit-by-commit
DefaulttoAppLabel'sSyncToRenderWorld = SyncToSubWorld<RenderApp>andRenderEntity = SubEntity<RenderApp>entity_sync_systemto useAppLabel(ExtractPluginspecifiesentity_sync_system::<RenderApp>)ExtractInstanceto be explicit forRenderApp. UpdateExtractInstancesPluginto be generic onAppLabelExtractComponentPluginto be generic onL : AppLabel = RenderApp- in followup PR we will remove this default.ExtractResourcePluginandSyncComponentPlugin.SyncWorldPluginto be generic onAppLabel.ExtractPluginto be generic onAppLabel.RenderPluginto specifyExtractPlugin<RenderApp>.SyncComponentPluginto use an observer, rather than hookTesting
cargo run --example animated_mesh