Skip to content

Solari: Add russian roulette to specular pt #23898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 1 commit into from
Apr 21, 2026
Merged

Solari: Add russian roulette to specular pt #23898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/bevy_solari/src/realtime/specular_gi.wgsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ enable wgpu_ray_query;

#define_import_path bevy_solari::specular_gi

#import bevy_core_pipeline::tonemapping::tonemapping_luminance as luminance
#import bevy_pbr::pbr_functions::{calculate_tbn_mikktspace, calculate_diffuse_color, calculate_F0}
#import bevy_pbr::utils::rand_f
#import bevy_render::maths::{orthonormalize, PI}
#import bevy_render::view::View
#import bevy_solari::brdf::{evaluate_brdf, evaluate_specular_brdf}
Expand Down Expand Up @@ -156,6 +158,11 @@ fn trace_glossy_path(pixel_id: vec2<u32>, primary_surface: ResolvedGPixel, initi
throughput /= p_bounce;
}

// Russian roulette for early termination
Comment thread
alice-i-cecile marked this conversation as resolved.
let p = luminance(throughput);
if rand_f(rng) > p { break; }
throughput /= p;

// Path spread increase
path_spread += path_spread_heuristic(ray.t, ray_hit.material.roughness);
}
Expand Down