Skip to content

Solari: Add russian roulette to specular pt#23898

Merged
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
JMS55:solari6-specular-rr
Apr 21, 2026
Merged

Solari: Add russian roulette to specular pt#23898
alice-i-cecile merged 1 commit into
bevyengine:mainfrom
JMS55:solari6-specular-rr

Conversation

@JMS55

@JMS55 JMS55 commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Save some performance on specular indirect.

Todo in the future:

  • Investigate if we have to clamp p at all
  • Investigate subgroup-level RR schemes like nvidia used for further perf improvements

@JMS55 JMS55 requested a review from SparkyPotato April 20, 2026 15:14
@JMS55 JMS55 added A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times labels Apr 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Apr 20, 2026
@JMS55 JMS55 added this to the 0.20 milestone Apr 20, 2026
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Apr 20, 2026
Comment thread crates/bevy_solari/src/realtime/specular_gi.wgsl
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 20, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 21, 2026
Merged via the queue into bevyengine:main with commit 8b2aa00 Apr 21, 2026
47 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants