Skip to content

fix: update Node.js version to 24.x in workflow#185

Merged
taoyong-ty merged 7 commits intoaws-actions:mainfrom
scottschreckengaust:patch-1
Apr 14, 2026
Merged

fix: update Node.js version to 24.x in workflow#185
taoyong-ty merged 7 commits intoaws-actions:mainfrom
scottschreckengaust:patch-1

Conversation

@scottschreckengaust
Copy link
Copy Markdown
Contributor

@scottschreckengaust scottschreckengaust commented Apr 13, 2026

Description of changes

  • Update GitHub Actions from Node20 to Node24
  • Fix dependency issues that break tests and resolve all npm audit findings.

Changes

  1. Upgrade Node — 20 to 24 in GitHub Workflow files too (not just the action.yml from PR Upgrade to Node.js 24 #183 )

  2. Downgrade @actions/github to ^8.0.1 — v9+ is ESM-only and incompatible with this project's CommonJS require() usage, causing ERR_PACKAGE_PATH_NOT_EXPORTED at runtime and in tests.

  3. Upgrade mocha from ^10.1.0 to ^11.7.5 — brings test framework to latest.

  4. Resolve npm audit findings — add overrides in package.json for transitive dependencies pinned by mocha and eslint to semver ranges that exclude patched versions. Run npm audit fix for remaining direct dependency updates.

Result

  • All 23 tests passing
  • 0 npm audit vulnerabilities

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

scottschreckengaust and others added 7 commits April 13, 2026 13:38
@actions/github v9+ is ESM-only and incompatible with this project's
CommonJS require() usage. v8.0.1 is the latest CJS-compatible release
with the same API surface.
Add npm overrides for transitive dependencies pinned by mocha and
eslint to versions outside their semver ranges. Run npm audit fix
for remaining direct dependency updates.

Result: 0 vulnerabilities, all 23 tests passing.
@scottschreckengaust scottschreckengaust marked this pull request as ready for review April 13, 2026 21:15
@taoyong-ty taoyong-ty merged commit 85cb4d9 into aws-actions:main Apr 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants