feat: convert project from CommonJS to ESM#186
Open
scottschreckengaust wants to merge 7 commits intoaws-actions:mainfrom
Open
feat: convert project from CommonJS to ESM#186scottschreckengaust wants to merge 7 commits intoaws-actions:mainfrom
scottschreckengaust wants to merge 7 commits intoaws-actions:mainfrom
Conversation
- Add "type": "module" to package.json - Convert all require()/module.exports to import/export - Upgrade @actions/core ^1.10.0 -> ^3.0.0 (ESM-only) - Upgrade @actions/github ^8.0.1 -> ^9.1.0 (ESM-only) - Upgrade uuid ^3.4.0 -> ^9.0.0 (ESM import path) - Upgrade yargs ^15.3.1 -> ^17.7.2 (ESM support) - Upgrade @vercel/ncc ^0.36.1 -> ^0.38.4 (ESM input) - Upgrade chai ^4.2.0 -> ^6.2.2 (ESM-native) - Update ESLint config for ESM (sourceType: module) - Rework test context mutation for ESM live bindings All 23 tests passing, 0 audit vulnerabilities, ncc build succeeds.
ncc v0.38 code-splits ESM output into chunks, which is unreliable for GitHub Actions runners. esbuild produces a single dist/index.js with a createRequire banner shim for CJS interop.
Accept an optional context parameter (defaults to github.context) so tests can pass plain objects instead of mutating the shared @actions/github singleton.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Convert the project from CommonJS to ECMAScript Modules (ESM).
What changed
"type": "module"topackage.jsonrequire()/module.exportstoimport/export@vercel/nccbundler withesbuild— produces a singledist/index.js(ncc code-splits ESM into unreliable chunks)github.contextas a parameter intogithubInputs()for testability — tests now pass plain context objects instead of mutating the shared@actions/githubsingletonsourceType: "module",ecmaVersion: 2022Dependencies upgraded
@actions/core^1.10.0^3.0.0@actions/github^8.0.1^9.1.0uuid^3.4.0^9.0.0yargs^15.3.1^17.7.2chai^4.2.0^6.2.2@vercel/ncc^0.36.1esbuildesbuild^0.28.0Verification
esbuildproduces a singledist/index.js(no chunks)npm run lintcleannpm audit— 0 vulnerabilitiesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: