Skip to content

[YUNIKORN-3285] Quota preemption delay inheritance test fix #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adityadtu5 wants to merge 4 commits into from
+7 −5
Closed

[YUNIKORN-3285] Quota preemption delay inheritance test fix #1031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4966bc
[YUNIKORN-3285] Quota preemption delay inheritance test fix
adityadtu5 May 20, 2026
5fd92a4
increased wait
adityadtu5 May 20, 2026
d8fb278
Merge branch 'apache:master' into YUNIKORN-3285
adityadtu5 Jun 5, 2026
93d098d
updated k8shim version
adityadtu5 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module github.com/apache/yunikorn-k8shim
go 1.25.0

require (
github.com/apache/yunikorn-core v0.0.0-20260529102538-fad16fdb6992
github.com/apache/yunikorn-core v0.0.0-20260605065500-fae6e256cd5c
github.com/apache/yunikorn-scheduler-interface v0.0.0-20260528033204-c474acff6d53
github.com/google/go-cmp v0.7.0
github.com/google/uuid v1.6.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ github.com/alexbrainman/sspi v0.0.0-20250919150558-7d374ff0d59e h1:4dAU9FXIyQktp
github.com/alexbrainman/sspi v0.0.0-20250919150558-7d374ff0d59e/go.mod h1:cEWa1LVoE5KvSD9ONXsZrj0z6KqySlCCNKHlLzbqAt4=
github.com/antlr4-go/antlr/v4 v4.13.0 h1:lxCg3LAv+EUK6t1i0y1V6/SLeUi0eKEKdhQAlS8TVTI=
github.com/antlr4-go/antlr/v4 v4.13.0/go.mod h1:pfChB/xh/Unjila75QW7+VU4TSnWnnk9UTnmpPaOR2g=
github.com/apache/yunikorn-core v0.0.0-20260529102538-fad16fdb6992 h1:eOO7ADGZwpv8yc/bNMA2TQFq1izvzuisZdjj+POHHj4=
github.com/apache/yunikorn-core v0.0.0-20260529102538-fad16fdb6992/go.mod h1:yxn4stqkqgiSNYqOyulBHf9IgyTBM+rFrzWcyicueKU=
github.com/apache/yunikorn-core v0.0.0-20260605065500-fae6e256cd5c h1:iuShQ3op12fL+jQ420ZQLsgyDp/1L1/ygi9ZG8awvko=
github.com/apache/yunikorn-core v0.0.0-20260605065500-fae6e256cd5c/go.mod h1:yxn4stqkqgiSNYqOyulBHf9IgyTBM+rFrzWcyicueKU=
github.com/apache/yunikorn-scheduler-interface v0.0.0-20260528033204-c474acff6d53 h1:zodKoODatR57zSGoQGdQ8EZjJgQqy9nh5/yxmI9hWpI=
github.com/apache/yunikorn-scheduler-interface v0.0.0-20260528033204-c474acff6d53/go.mod h1:XygReHrRd3TtfNS3uVtRQI0sCOfprcLUfhlmv/LdCmk=
github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5 h1:0CwZNZbxp69SHPdPJAN/hZIm0C4OItdklCFmMRWYpio=
Expand Down
6 changes: 4 additions & 2 deletions test/e2e/quota-preemption/quota_preemption_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ var _ = ginkgo.Describe("QuotaPreemption", func() {
}, 5*time.Second, time.Second).Should(gomega.Succeed())
})

ginkgo.PIt("Needs Investigation - Quota_Preemption_Delay_Inherited_From_Parent", func() {
ginkgo.It("Quota_Preemption_Delay_Inherited_From_Parent", func() {
ginkgo.By("Quota preemption delay set on parent queue should be inherited by child queues that do not set it explicitly.")

// Apply initial config: parent has quota.preemption.delay=20s, child (queue-a) has no delay set.
Expand All @@ -313,7 +313,9 @@ var _ = ginkgo.Describe("QuotaPreemption", func() {
Ω(err).NotTo(gomega.HaveOccurred())

ginkgo.By("Waiting for all 3 deployment pods to be running")
err = kClient.WaitForPodBySelectorRunning(dev, "app=app-a", 30)
err = kClient.WaitForPodBySelector(dev, "app=app-a", 20*time.Second)
Ω(err).NotTo(gomega.HaveOccurred())
err = kClient.WaitForPodBySelectorRunning(dev, "app=app-a", 10)
Ω(err).NotTo(gomega.HaveOccurred())
ginkgo.By("All 3 pods are running before quota is reduced")

Expand Down
Loading