Skip to content

[YUNIKORN-3285] Quota preemption delay inheritance test fix#1031

Closed
adityadtu5 wants to merge 4 commits into
apache:masterfrom
adityadtu5:YUNIKORN-3285
Closed

[YUNIKORN-3285] Quota preemption delay inheritance test fix#1031
adityadtu5 wants to merge 4 commits into
apache:masterfrom
adityadtu5:YUNIKORN-3285

Conversation

@adityadtu5
Copy link
Copy Markdown
Contributor

What is this PR for?

Enabling test for quota preemption delay inheritance, after applying fix in core apache/yunikorn-core#1088

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-3285

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.97%. Comparing base (cad899d) to head (93d098d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   68.07%   67.97%   -0.10%     
==========================================
  Files          73       73              
  Lines        7520     7520              
==========================================
- Hits         5119     5112       -7     
- Misses       2192     2198       +6     
- Partials      209      210       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: the change is OK, the test still seems to fail for all versions. Did this just shift the failure to a later part of the test?
Not committing the change yet.

@wilfred-s
Copy link
Copy Markdown
Contributor

@adityadtu5 the core changes have been committed, does this PR need a rebase or is there some test change that is required?

@adityadtu5
Copy link
Copy Markdown
Contributor Author

@adityadtu5 the core changes have been committed, does this PR need a rebase or is there some test change that is required?

@wilfred-s , core changes are not yet merged. apache/yunikorn-core#1088
First we need to merge core changes and then I need to update core version in go.mod

@wilfred-s wilfred-s closed this in 7548c69 Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants