Skip to content

[YUNIKORN-3285] Child queue is not inheriting parent queue propertie…#1088

Closed
adityadtu5 wants to merge 8 commits into
apache:masterfrom
adityadtu5:YUNIKORN-3285
Closed

[YUNIKORN-3285] Child queue is not inheriting parent queue propertie…#1088
adityadtu5 wants to merge 8 commits into
apache:masterfrom
adityadtu5:YUNIKORN-3285

Conversation

@adityadtu5
Copy link
Copy Markdown
Contributor

…s during queue update

What is this PR for?

  • Merging parent queue property to child queue during queue update
  • Added UT for it

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-3285

How should this be tested?

UTs are part of this PR

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@adityadtu5 adityadtu5 marked this pull request as draft May 20, 2026 12:50
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.48%. Comparing base (2453bc2) to head (80d2b1b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/scheduler/objects/queue.go 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1088   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files         103      103           
  Lines       13963    13974   +11     
=======================================
+ Hits        11378    11387    +9     
- Misses       2309     2311    +2     
  Partials      276      276           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/scheduler/objects/queue.go
Comment thread pkg/scheduler/objects/queue.go Outdated
@adityadtu5 adityadtu5 requested a review from wilfred-s May 29, 2026 09:05
Comment thread pkg/scheduler/objects/queue.go
Comment thread pkg/scheduler/objects/queue_test.go Outdated
@adityadtu5 adityadtu5 requested a review from wilfred-s June 4, 2026 05:24
Copy link
Copy Markdown
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pkg/scheduler/objects/queue_test.go Outdated
@adityadtu5 adityadtu5 requested a review from wilfred-s June 4, 2026 10:44
Copy link
Copy Markdown
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
Waiting for build to finish before commit

@wilfred-s wilfred-s closed this in fae6e25 Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants