feat: support viz interface#2881
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2881 +/- ##
==========================================
- Coverage 84.38% 82.63% -1.76%
==========================================
Files 92 92
Lines 10948 11218 +270
==========================================
+ Hits 9239 9270 +31
- Misses 1709 1948 +239 |
Contributor
|
The documentation for this pull request will be available at https://dpf.docs.pyansys.com/pull/2881. Please allow some time for the documentation to be deployed. |
3e6c1a8 to
c17da74
Compare
5184748 to
08b6a47
Compare
08b6a47 to
dc070de
Compare
0b28d0a to
40d7eda
Compare
40d7eda to
5b2fa76
Compare
PProfizi
reviewed
Mar 2, 2026
PProfizi
reviewed
Mar 2, 2026
a48e01e to
35f20ac
Compare
35f20ac to
8ad1baf
Compare
PProfizi
approved these changes
Mar 2, 2026
Contributor
|
This PR has been closed. Documentation for this pull request will shortly be removed from its former deployment address. |
1 similar comment
Contributor
|
This PR has been closed. Documentation for this pull request will shortly be removed from its former deployment address. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2841.
Summary of changes
_VisualizationInterfacePlotterclass has been added. Since viz'sPlotlyBackenddoesn't support volumetric meshes like thePyVistaBackenddoes, we are pluggingpydpf-core's plotter to only the latter._PyVistaPlotteryet, since other classes likePlotterandAnimatordepends on it. Once those are gradually phased out via separate PRs in the future, we will eventually be able to deprecate_PyVistaPlotter.plotter_typeargument that can be one ofPlotterBackend.VISUALIZATION_INTERFACE,PlotterBackend.PYVISTA, andPlotterBackend.AUTO. The behavior is as follows:PlotterBackend.AUTOis the default. This will select the new plotter or the legacy plotter depending on which one is available in the user's environment. This guarantees that plotting scripts won't automatically start breaking if users updatepydpf-corewithout updating it's plotting dependencies.PlotterBackend.PYVISTAwill select the legacy plotter andPlotterBackend.VISUALIZATION_INTERFACEwill select the new plotter.@PProfizi and @jorgepiloto, this is now ready for review.
Note
We will address switching to the viz-interface as the default backend in a separate PR. It requires making sure all tests pass and that might require a bit more work.