tests: revert

Author: moe-ad

.github/workflows/tests.yml

@@ -266,19 +266,6 @@ jobs:
             export DPF_DEFAULT_GRPC_MODE=insecure
             tox --installpkg "$TOX_INSTALLPKG" ${TOX_XARG:+-x "$TOX_XARG"} -e test-api_entry,kill-servers
 
-      - name: "Test API test_api"
-        uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3.0.2
-        env:
-          TOX_INSTALLPKG: ${{ steps.tox-cli-arguments.outputs.TOX_INSTALLPKG }}
-          TOX_XARG: ${{ steps.tox-cli-arguments.outputs.TOX_XARG }}
-        with:
-          timeout_minutes: 10
-          max_attempts: 2
-          shell: bash
-          command: |
-            export DPF_DEFAULT_GRPC_MODE=insecure
-            tox --installpkg "$TOX_INSTALLPKG" ${TOX_XARG:+-x "$TOX_XARG"} -e test-api,kill-servers
-
       - name: "Run compatible tests in parallel"
         uses: nick-fields/retry@ce71cc2ab81d554ebbe88c79ab5975992d79ba08 # v3.0.2
         env:

pyproject.toml

@@ -97,7 +97,6 @@ doc = [
 test = [
   "ansys-platform-instancemanagement==1.1.2",
   "ansys-tools-common==0.4.3",
-  "ansys-tools-visualization-interface==1.0.0a1",
   "coverage==7.13.4",
   "graphviz==0.21",
   "imageio==2.37.2",

src/ansys/dpf/core/server_types.py

@@ -174,15 +174,13 @@ def _run_launch_server_process(
 def _wait_and_check_server_connection(
     process, port, timeout, lines, current_errors, stderr=None, stdout=None
 ):
-    lock = Lock()
     if not stderr:
 
         def read_stderr():
             with io.TextIOWrapper(process.stderr, encoding="utf-8") as log_err:
                 for line in log_err:
                     LOG.debug(line)
-                    with lock:
-                        current_errors.append(line)
+                    current_errors.append(line)
 
         stderr = read_stderr
         # check to see if the service started
@@ -192,8 +190,7 @@ def read_stdout():
             with io.TextIOWrapper(process.stdout, encoding="utf-8") as log_out:
                 for line in log_out:
                     LOG.debug(line)
-                    with lock:
-                        lines.append(line)
+                    lines.append(line)
 
         stdout = read_stdout
     # must be in the background since the process reader is blocking
@@ -203,12 +200,9 @@ def read_stdout():
     t_timeout = time.time() + timeout
     started = False
     timedout = False
-    while True:
-        with lock:
-            has_errors = len(current_errors) > 0
-            started = any("server started" in line for line in lines)
-        if started or has_errors:
-            break
+    while not started and len(current_errors) == 0:
+        # print(lines)
+        started = any("server started" in line for line in lines)
 
         if time.time() > t_timeout:
             if timedout:
@@ -218,14 +212,12 @@ def read_stdout():
 
     # verify there were no errors
     time.sleep(0.01)
-    with lock:
-        snapshot_errors = list(current_errors)
-    if snapshot_errors:
+    if current_errors:
         try:
             process.kill()
         except PermissionError:
             pass
-        errstr = "\n".join(snapshot_errors)
+        errstr = "\n".join(current_errors)
         if (
             "Only one usage of each socket address" in errstr
             or "port is already allocated" in errstr

tox.ini

@@ -34,7 +34,7 @@ envlist = pretest,test-{api,documentation,launcher,server,local_server,multi_ser
 labels =
     localparalleltests = pretest,test-{api,documentation,launcher,server,local_server,multi_server,custom_type_field,operators,server_errors},posttest,kill-servers
     othertests = pretest,test-{workflow,remote_workflow,remote_operator,service},posttest,kill-servers
-    ciparalleltests = test-{documentation,launcher,local_server,multi_server,custom_type_field,operators,server_errors},kill-servers
+    ciparalleltests = test-{api,documentation,launcher,local_server,multi_server,custom_type_field,operators,server_errors},kill-servers
 
 isolated_build_env = build