Skip to content

Remove QtCharts dependency from SFM stats and CRF viewer #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Remove QtCharts dependency from SFM stats and CRF viewer #3052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05a169f
Replace QtCharts in StatViewer with Canvas-based LineChart and LineCh…
Copilot Mar 20, 2026
fa9bc09
Address code review: rename ambiguous loop var, extract color helper …
Copilot Mar 20, 2026
e6fb7e9
Fix Ctrl+click solo mode and add missing GPU legend
Copilot Mar 20, 2026
cc0627d
Replace QtCharts with Canvas-based LineChart in CameraResponseGraph
Copilot Mar 20, 2026
93099f1
Replace QtCharts with Canvas-based LineChart in SfmStatsView and SfmG…
Copilot Mar 20, 2026
7ff014b
Remove remaining QtCharts files, qmldir entries, and Docker addon ref…
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile_rocky_deps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ RUN chmod +x qt.run
RUN ./qt.run --root /opt/Qt --verbose --email ${QT_CI_LOGIN} --password ${QT_CI_P} --accept-obligations \
--accept-licenses --default-answer --platform minimal --auto-answer installationErrorWithCancel=Ignore \
--no-force-installations --no-default-installations --confirm-command \
install qt.qt6.683.linux_gcc_64 qt.qt6.683.addons.qtcharts qt.qt6.683.addons.qt3d
install qt.qt6.683.linux_gcc_64 qt.qt6.683.addons.qt3d
RUN rm qt.run

# Strip sections containing ".note.ABI.tag" from .so: https://github.com/Microsoft/WSL/issues/3023
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile_ubuntu_deps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ RUN chmod +x qt.run
RUN ./qt.run --root /opt/Qt --verbose --email ${QT_CI_LOGIN} --password ${QT_CI_P} --accept-obligations \
--accept-licenses --default-answer --platform minimal --auto-answer installationErrorWithCancel=Ignore \
--no-force-installations --no-default-installations --confirm-command \
install qt.qt6.683.linux_gcc_64 qt.qt6.683.addons.qtcharts qt.qt6.683.addons.qt3d
install qt.qt6.683.linux_gcc_64 qt.qt6.683.addons.qt3d
RUN rm qt.run

# Strip sections containing ".note.ABI.tag" from .so: https://github.com/Microsoft/WSL/issues/3023
Expand Down
10 changes: 0 additions & 10 deletions meshroom/ui/components/csvData.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from meshroom.common.qt import QObjectListModel

from PySide6.QtCore import QObject, Slot, Signal, Property
from PySide6 import QtCharts

import csv
import os
Expand Down Expand Up @@ -112,14 +111,5 @@ def getLast(self):
return ""
return self._content[-1]

@Slot(QtCharts.QXYSeries)
def fillChartSerie(self, serie):
"""Fill XYSerie used for displaying QML Chart."""
if not serie:
return
serie.clear()
for index, value in enumerate(self._content):
serie.append(float(index), float(value))

title = Property(str, lambda self: self._title, constant=True)
content = Property("QStringList", lambda self: self._content, constant=True)
103 changes: 0 additions & 103 deletions meshroom/ui/qml/Charts/ChartViewLegend.qml
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions meshroom/ui/qml/Charts/InteractiveChartView.qml
View file
Open in desktop

This file was deleted.

Loading
Loading