Skip to content

Remove QtCharts dependency from SFM stats and CRF viewer#3052

Draft
Copilot wants to merge 6 commits intodevelopfrom
copilot/remove-qtcharts-dependency
Draft

Remove QtCharts dependency from SFM stats and CRF viewer#3052
Copilot wants to merge 6 commits intodevelopfrom
copilot/remove-qtcharts-dependency

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

  • Replace QtCharts with Canvas-based LineChart in CameraResponseGraph
  • Remove fillChartSerie / PySide6.QtCharts from csvData.py
  • Rewrite SfmStatsView.qml with LineChart (no QtCharts)
  • Rewrite SfmGlobalStats.qml with LineChart (no QtCharts)
  • Delete meshroom/ui/qml/Charts/ChartViewLegend.qml (unused, had import QtCharts)
  • Delete meshroom/ui/qml/Charts/InteractiveChartView.qml (unused, had import QtCharts)
  • Remove both deleted files from meshroom/ui/qml/Charts/qmldir
  • Remove qt.qt6.683.addons.qtcharts from docker/Dockerfile_rocky_deps
  • Remove qt.qt6.683.addons.qtcharts from docker/Dockerfile_ubuntu_deps

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 5 commits March 20, 2026 08:52
…artLegend components

Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
…function

Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
…lobalStats

Co-authored-by: fabiencastan <153585+fabiencastan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/alicevision/Meshroom/sessions/c691a49d-fe73-4e50-92a4-4b5d1b6b3a46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.40%. Comparing base (796e610) to head (7ff014b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3052   +/-   ##
========================================
  Coverage    83.40%   83.40%           
========================================
  Files           73       73           
  Lines         9870     9870           
========================================
  Hits          8232     8232           
  Misses        1638     1638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI requested a review from fabiencastan March 20, 2026 18:43
@fabiencastan fabiencastan marked this pull request as ready for review March 20, 2026 18:52
@fabiencastan fabiencastan added this to the Meshroom 2026.1.0 milestone Mar 20, 2026
@fabiencastan fabiencastan marked this pull request as draft April 10, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants