Skip to content

Drop 3.13t support #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webknjaz merged 9 commits into from
May 11, 2026
+3 −6
Merged

Drop 3.13t support #1326

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e0f676
Drop 3.13t builds from cibuildwheel configuration
ngoldbaum Apr 22, 2026
0689e58
drop 3.13t CI
ngoldbaum Apr 22, 2026
38108b7
add release note fragment
ngoldbaum Apr 22, 2026
3703214
add comment explaining lack of 3.13t testing
ngoldbaum Apr 23, 2026
ebc5d3d
Update CHANGES/1326.breaking.rst
ngoldbaum May 8, 2026
dbf39f4
Merge branch 'master' into rm-3.13t-builds
ngoldbaum May 11, 2026
4802823
Add symlink
ngoldbaum May 11, 2026
4077b59
remove symlink, just call it a packaging change
ngoldbaum May 11, 2026
760de41
fix symlink
ngoldbaum May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ jobs:
pyver:
- 3.14t
- 3.14
- 3.13t
# Skipping 3.13t because cibuildwheel dropped support
- 3.13
- 3.12
- 3.11
Expand All @@ -191,10 +191,6 @@ jobs:
no-extensions: Y
- os: windows
no-extensions: Y
- os: macos
pyver: 3.13t # this is still tested within cibuildwheel
- os: windows
pyver: 3.13t # this is still tested within cibuildwheel
- no-extensions: Y
debug: Y
include:
Expand Down
1 change: 1 addition & 0 deletions CHANGES/1326.breaking.rst
View file
Open in desktop
Copy link
Copy Markdown
Member

@webknjaz webknjaz Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you symlink think to packaging? Also, I'm not sure if this counts as breaking.

cc @Dreamsorcerer @bdraco WDYT?

Copy link
Copy Markdown
Member

@webknjaz webknjaz May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngoldbaum have you missed the symlink request?

Copy link
Copy Markdown
Contributor Author

@ngoldbaum ngoldbaum May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I misunderstood what you were referring to with the symlink. See latest push.

Copy link
Copy Markdown
Contributor Author

@ngoldbaum ngoldbaum May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except it looks like towncrier doesn't like symlinks, so I just removed the breaking note and called it packaging.

Copy link
Copy Markdown
Member

@webknjaz webknjaz May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngoldbaum Towncrier works with symlinks just fine. This replaces having two text files with exactly the same contents 🤷‍♂️

The failure in your previous commit was caused by an HTTP 500 when uploading MyPy type preciseness coverage to Coveralls: https://github.com/aio-libs/multidict/actions/runs/25672626609/job/75361690773?pr=1326#step:8:232

Copy link
Copy Markdown
Member

@webknjaz webknjaz May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure restarting that job will make it green..

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Dropped support for free-threaded Python 3.13 -- by :user:`ngoldbaum`.
1 change: 1 addition & 0 deletions CHANGES/1326.packaging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
CHANGES/1326.breaking.rst
Copy link
Copy Markdown
Member

@webknjaz webknjaz May 11, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngoldbaum the problem here was that you've added a symlink relative to the repo root and so any tooling resolving it, would search for CHANGES/CHANGES/1326.packaging.rst. The correct way would be running ln -s in the CHANGES/ dir so that the relative link points to just 1326.packaging.rst w/o the dir prefix...

Copy link
Copy Markdown
Contributor Author

@ngoldbaum ngoldbaum May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining, see latest commit.

1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ test-requires = "-r requirements/pytest.txt"
test-command = 'pytest -m "not leaks" --no-cov {project}/tests'
# don't build PyPy wheels, install from source instead
skip = "pp*"
enable = ["cpython-freethreading"]

[tool.cibuildwheel.linux]
# Re-enable 32-bit builds (disabled by default in cibuildwheel 3.0)
Expand Down
Loading