-
Notifications
You must be signed in to change notification settings - Fork 74
Fixed initializing the GPG callbacks during registration #3395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
0611a48
a7d9378
2f30bb4
8ef3273
a27641e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,6 +76,7 @@ impl Service { | |
|
|
||
| self.config.as_ref().and_then(|config| { | ||
| if let Some(Policy::Auto) = config.policy { | ||
| tracing::info!("Returning automatic answer: {:?}", &spec.default_action); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would at least print some info about question so it is easier to see which question gets automatic answer. |
||
| spec.default_action.clone().map(|action| Answer { | ||
| action, | ||
| value: None, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| #ifndef C_LOGGING_HXX_ | ||
| #define C_LOGGING_HXX_ | ||
|
|
||
| #include <string> | ||
|
|
||
| #include <systemd/sd-journal.h> | ||
|
|
||
| // helper macro for logging messages to systemd journal | ||
| #define LOG(level, message) \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we really need another logger? we already have macros from libzypp that logs to journal - https://github.com/agama-project/agama/blob/master/rust/zypp-agama/zypp-agama-sys/c-layer/lib.cxx#L195 |
||
| do { \ | ||
| std::string line("CODE_LINE="); \ | ||
| line.append(std::to_string(__LINE__)); \ | ||
| sd_journal_send_with_location( \ | ||
| "CODE_FILE=" __FILE__, line.c_str(), __func__, "PRIORITY=%i", (level), \ | ||
| "MESSAGE=%s", (message), "COMPONENT=zypp-agama-sys", NULL); \ | ||
| } while (0) | ||
|
|
||
| #endif | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI: This is the root of the problem, using empty callbacks.