Fixed initializing the GPG callbacks during registration#3395
Open
Fixed initializing the GPG callbacks during registration#3395
Conversation
- Expect the GPG key fingerpring in the question aswers in the human-readable format with space separators
lslezak
commented
Apr 17, 2026
| .map_err(|e| RegistrationError::RefreshService(name.clone(), e))?; | ||
| zypp.load_source( | ||
| zypp_agama::callbacks::empty_progress, | ||
| &mut zypp_agama::callbacks::security::EmptyCallback, |
Contributor
Author
There was a problem hiding this comment.
JFYI: This is the root of the problem, using empty callbacks.
lslezak
changed the title
jreidinger
reviewed
Apr 17, 2026
|
|
||
| self.config.as_ref().and_then(|config| { | ||
| if let Some(Policy::Auto) = config.policy { | ||
| tracing::info!("Returning automatic answer: {:?}", &spec.default_action); |
Contributor
There was a problem hiding this comment.
I would at least print some info about question so it is easier to see which question gets automatic answer.
jreidinger
reviewed
Apr 17, 2026
| #include <systemd/sd-journal.h> | ||
|
|
||
| // helper macro for logging messages to systemd journal | ||
| #define LOG(level, message) \ |
Contributor
There was a problem hiding this comment.
do we really need another logger? we already have macros from libzypp that logs to journal - https://github.com/agama-project/agama/blob/master/rust/zypp-agama/zypp-agama-sys/c-layer/lib.cxx#L195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Testing
Logs showing importing the GPG key