Skip to content

[Statistics] Catch-up all languages to fr + Fix hindi plural across modules#10724

Merged
driusan merged 5 commits into
aces:29.0-releasefrom
skarya22:2026_06_30_Catchup_Statistics_POs
Jun 30, 2026
Merged

[Statistics] Catch-up all languages to fr + Fix hindi plural across modules#10724
driusan merged 5 commits into
aces:29.0-releasefrom
skarya22:2026_06_30_Catchup_Statistics_POs

Conversation

@skarya22

@skarya22 skarya22 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

  • Catch-up PO files in statistics to match french

Testing instructions (if applicable)

  1. Open statistics module in chinese, hindi and japanese and ensure all non-db values are translated.

@skarya22 skarya22 changed the base branch from main to 29.0-release June 30, 2026 18:37
@github-actions github-actions Bot added Language: SQL PR or issue that update SQL code RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: statistics PR or issue related to statistics module Module: api PR or issue related to api module Module: candidate_parameters PR or issue related to candidate_parameters module Module: candidate_profile PR or issue related to candidate_profile module Module: configuration PR or issue related to configuration module Module: dictionary PR or issue related to (new) dictionary module Module: electrophysiology_browser PR or issue related to electrophysiology_browser module Module: imaging_browser PR or issue related to imaging_browser module Module: imaging_uploader PR or issue related to imaging_uploader module Module: instrument_list PR or issue related to instrument_list module Module: instrument_manager PR or issue related to instrument_manager module Module: instruments PR or issue related to instruments module Module: login PR or issue related to login module Module: media PR or issue related to media module Module: module_manager PR or issue related to module_manager module Module: oidc PR or issue related to the oidc (OpenID Connect) module Module: publication PR or issue related to the publication module Module: survey_accounts PR or issue related to the survey_accounts module Module: timepoint_list PR or issue related to the timepoint_list module Module: user_accounts PR or issue related to the user_accounts module Module: data_release PR or issue related to data_release module Module: dataquery PR or issue related to (new) dataquery module Multilingual Any tasks related to making LORIS multilingual Module: redcap PR or issue related to redcap module labels Jun 30, 2026
@skarya22 skarya22 added 29.0.0 - Bugs Issues found during the release testing for 29.0.0 and removed Module: instruments PR or issue related to instruments module Module: login PR or issue related to login module Module: media PR or issue related to media module Module: module_manager PR or issue related to module_manager module Module: oidc PR or issue related to the oidc (OpenID Connect) module Module: publication PR or issue related to the publication module Module: survey_accounts PR or issue related to the survey_accounts module Module: timepoint_list PR or issue related to the timepoint_list module Module: user_accounts PR or issue related to the user_accounts module Module: data_release PR or issue related to data_release module Module: dataquery PR or issue related to (new) dataquery module Module: redcap PR or issue related to redcap module labels Jun 30, 2026
driusan
driusan reviewed Jun 30, 2026
View reviewed changes
Comment thread modules/statistics/locale/ja/LC_MESSAGES/statistics.po Outdated
@skarya22 @driusan
Update modules/statistics/locale/ja/LC_MESSAGES/statistics.po
4eb4bd6 
Co-authored-by: Dave MacFarlane <driusan@gmail.com>
@skarya22 skarya22 requested a review from driusan June 30, 2026 18:41
driusan
driusan reviewed Jun 30, 2026
View reviewed changes
Comment thread modules/statistics/locale/statistics.pot Outdated
msgid "Dataset Size"
msgid_plural "Dataset Size"
msgstr[0] ""
msgstr[1] ""

@driusan driusan Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to add this to the template, the number that exist depend on the language.. the msgstr[0] is just so that we keep in mind that the array index is necessary when doing a new language and can't just use "msgstr"

driusan
driusan reviewed Jun 30, 2026
View reviewed changes
Comment thread modules/statistics/locale/hi/LC_MESSAGES/statistics.po
@github-actions github-actions Bot added Module: issue_tracker PR or issue related to issue tracker module Module: behavioural_qc PR or issue related behavioural_qc module Module: imaging_browser PR or issue related to imaging_browser module Module: dataquery PR or issue related to (new) dataquery module labels Jun 30, 2026
@skarya22 skarya22 changed the title [Statistics] Catch-up all languages to fr [Statistics] Catch-up all languages to fr + Fix hindi plural across modules Jun 30, 2026
@skarya22 skarya22 requested a review from driusan June 30, 2026 18:54
@driusan

driusan commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Test is failing because of a network error, will restart it after the rest run

@driusan driusan merged commit 9b8827c into aces:29.0-release Jun 30, 2026
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driusan driusan driusan approved these changes

Assignees

No one assigned

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Module: behavioural_qc PR or issue related behavioural_qc module Module: dataquery PR or issue related to (new) dataquery module Module: imaging_browser PR or issue related to imaging_browser module Module: issue_tracker PR or issue related to issue tracker module Module: statistics PR or issue related to statistics module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skarya22 @driusan