Skip to content

[docs repo] fix can't edit a file, delete a file #10679

Open
kongtiaowang wants to merge 10 commits into
aces:29.0-releasefrom
kongtiaowang:2026-06-22-fix-doc-edit
Open

[docs repo] fix can't edit a file, delete a file #10679
kongtiaowang wants to merge 10 commits into
aces:29.0-releasefrom
kongtiaowang:2026-06-22-fix-doc-edit

Conversation

@kongtiaowang

@kongtiaowang kongtiaowang commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

document repo can't edit a file.
#10593
document repo can't detele a file.
#10592
after run
"target=document_repository npm run compile" to test

@kongtiaowang kongtiaowang added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jun 22, 2026
@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Module: document_repository PR or issue related to documen_repository module labels Jun 22, 2026
@CamilleBeau CamilleBeau added the Critical to release PR or issue is key for the release to which it has been assigned label Jun 25, 2026
lapadulamichael

This comment was marked as outdated.

@lapadulamichael lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Jun 29, 2026
@lapadulamichael lapadulamichael removed the Passed manual tests PR has been successfully tested by at least one peer label Jun 29, 2026
@github-actions github-actions Bot added the Language: Javascript PR or issue that update Javascript code label Jun 29, 2026
@kongtiaowang kongtiaowang changed the title [docs repo] fix perm check [docs repo] fix can't edit a file, delete a file Jun 29, 2026

@lapadulamichael lapadulamichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lapadulamichael lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Jun 30, 2026
Comment thread modules/document_repository/php/files.class.inc
@kongtiaowang kongtiaowang requested a review from driusan June 30, 2026 17:27
@driusan

driusan commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

@kongtiaowang I don't understand why the "Files" became "Videos" in this PR. Doesn't the document repository mostly consist of non-video files?

Some of the references to "video" in the diff seem to already exist, but wouldn't it make more sense to change those to "File" instead of changing the "File" references to "Video"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Critical to release PR or issue is key for the release to which it has been assigned Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: document_repository PR or issue related to documen_repository module Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants