Skip to content

Add underline button to rich text formatting toolbar #78561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanfra wants to merge 2 commits into
base: trunk
Choose a base branch
from
+11 −1
Open

Add underline button to rich text formatting toolbar #78561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc9e9e7
Add underline toolbar button to format library
juanfra May 22, 2026
334514a
Merge branch 'trunk' into try/toolbar-richbutton-add-underline
juanfra May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/format-library/src/underline/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ import { __ } from '@wordpress/i18n';
import { toggleFormat } from '@wordpress/rich-text';
import {
RichTextShortcut,
RichTextToolbarButton,
__unstableRichTextInputEvent,
} from '@wordpress/block-editor';
import { formatUnderline } from '@wordpress/icons';

const name = 'core/underline';
const title = __( 'Underline' );
Expand All @@ -19,7 +21,7 @@ export const underline = {
attributes: {
style: 'style',
},
edit( { value, onChange } ) {
edit( { isActive, value, onChange, onFocus } ) {
const onToggle = () => {
onChange(
toggleFormat( value, {
Expand All @@ -30,6 +32,7 @@ export const underline = {
title,
} )
);
onFocus();
};

return (
Expand All @@ -43,6 +46,13 @@ export const underline = {
inputType="formatUnderline"
onInput={ onToggle }
/>
<RichTextToolbarButton
icon={ formatUnderline }
title={ title }
onClick={ onToggle }
isActive={ isActive }
role="menuitemcheckbox"
/>
</>
);
},
Expand Down
Loading