Add underline button to rich text formatting toolbar#78561
Open
juanfra wants to merge 2 commits into
Open
Conversation
juanfra
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +129 B (0%) Total Size: 8.04 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds an underline button to the rich text formatting toolbar, making it accessible via UI instead of requiring the keyboard shortcut.
Why?
There's no UI button to underline text, which creates a poor experience for a text editor. Users need to know the Cmd/Ctrl+U keyboard shortcut or they can't underline inline text at all. There's an option to do it in Typography > Decoration setting, but it only works on entire blocks, not a few words within a paragraph.
I've been surprised to find this, and while researching I've found that the criteria we've been following is that this was removed in tinymce 10 years ago (in 2016) over concerns that underlined text could be confused with links.
Ten years later, it sounds like a good time to revisit this. @m recently removed the theme requirement that links must be underlined. If we're not enforcing underlined links anymore, that original concern feels less relevant.
This is coming up every now and then (#7162, #43616, #47484, etc). We're basically limiting a standard formatting option to users who happen to know the keyboard shortcut. Underline is a basic feature in every major text editor. Let's give it a try.
How?
Adding the underline button to the rich text formatting toolbar. Uses the existing functionality, just exposes it in the UI.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
richtext-underline.mp4