Skip to content

Fix test replay log being automatically deleted#3771

Merged
nycrat merged 2 commits into
UBC-Thunderbots:masterfrom
nycrat:avah/fix_test_log_location
Jun 13, 2026
Merged

Fix test replay log being automatically deleted#3771
nycrat merged 2 commits into
UBC-Thunderbots:masterfrom
nycrat:avah/fix_test_log_location

Conversation

@nycrat

@nycrat nycrat commented Jun 13, 2026

Copy link
Copy Markdown
Member

Description

In #3766, we created symlinks to the bazel sandbox directory so that simulated tests won't interfere while running at the same time. However, this bazel directory is deleted automatically after the test ends so test replays are not saved. This PR simply turns these symlinks into persistent directories instead.

Testing Done

Ran a sim test, the replay is there after the test ends.

Resolved Issues

#3768

Length Justification and Key Files to Review

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@nycrat nycrat force-pushed the avah/fix_test_log_location branch from dcecf7a to 8b45bbc Compare June 13, 2026 21:22
@nycrat nycrat merged commit 159da85 into UBC-Thunderbots:master Jun 13, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants