Skip to content

Fix test replay logs uploaded as artifact in CI #3793

Description

@nycrat

Description of the task

After #3766 and #3771, the new location of replay logs for simulated tests are located in /tmp/tbots_abcdefgh where the last part of the directory is randomly generated. This is necessary for parallelized pytests, but now there is an issue that our github ci actions can't find the replay logs in /tmp/tbots/blue and /tmp/tbots/yellow anymore. We should fix this bug so that it is possible to download the test replay files to debug sim test failures in ci.

doesn't this break the CI uploads? The old code put test files in /tmp/tbots locally but this generates a random folder. But CI looks for log files in /tmp/tbots/blue/... and /tmp/tbots/yellow/... which show up in randomly named folders... I don't think CI can find them?
Could we bring back TEST_TMPDIR symlink behavior, default to /tmp/tbots locally like before. Then add something random to the path if you actually need to run tests at the same time?

Originally posted by @annieisawesome2 in #3744 (comment)

Acceptance criteria

  • After sim tests run in ci, all the test replays are uploaded in the artifacts
  • Pytests can still run in parallel

CURRENTLY WHAT IS UPLOADED:

Image

BEFORE THIS BUG:

Image

Blocked By

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugIssues that describe a bug and possibly a suggested solutionDifficulty - 3Easy and simple issues that require some context to doTestingField testing, test infrastructure, robot tuning

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions