Skip to content

fix(android): [SDK-4407] deliver notification events when firebase_messaging is present (#1138) #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fadi-george wants to merge 20 commits into
base: main
Choose a base branch
from

fix(android): register incoming-call handler on every engine messenger

f2c3f25
Select commit
Loading
Failed to load commit list.
Open

fix(android): [SDK-4407] deliver notification events when firebase_messaging is present (#1138) #1152

fix(android): register incoming-call handler on every engine messenger
f2c3f25
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 29, 2026 in 20m 24s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit android/src/main/java/com/onesignal/flutter/OneSignalNotifications.java:262-280 Stale clickListenerRequested flag in onAttachedToActivity new-engine branch

Annotations

Check warning on line 280 in android/src/main/java/com/onesignal/flutter/OneSignalNotifications.java

See this annotation in the file changed.

@claude claude / Claude Code Review

Stale clickListenerRequested flag in onAttachedToActivity new-engine branch 

nit: `onAttachedToActivity` returns early on the new-engine branch (OneSignalNotifications.java:263-268) without resetting the process-global `clickListenerRequested` field, so it retains the prior engine's Dart state. If a config change then fires on engine B before Dart B has called `addClickListener` (e.g. rotation during MainActivity cold start), the same-engine branch (lines 270-279) re-adds the native listener based on the stale flag and drains queued clicks into a Dart isolate whose user-
View more details on Claude