Skip to content

[18.0][FIX] pos_sale_picking_keep: Avoid crash on existing order updates #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pedrobaeza wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+4 −3
Open

[18.0][FIX] pos_sale_picking_keep: Avoid crash on existing order updates #1552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pos_sale_picking_keep/models/pos_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ def sync_from_ui(self, orders):
# Avoid the cancellation of the SO pickings
so_line_ids = []
for order_data in orders:
lines_data = order_data.get("lines", [])
for _, _, line_data in lines_data:
so_line_id = line_data.get("sale_order_line_id")
for command in order_data.get("lines", []):
if len(command) != 3:
continue # No create/update command
so_line_id = command[2].get("sale_order_line_id")
if so_line_id:
so_line_ids.append(so_line_id)
so_lines = self.env["sale.order.line"].browse(so_line_ids)
Expand Down
Loading