[18.0][FIX] pos_sale_picking_keep: Avoid crash on existing order updates#1552
Open
pedrobaeza wants to merge 1 commit into
Open
[18.0][FIX] pos_sale_picking_keep: Avoid crash on existing order updates#1552pedrobaeza wants to merge 1 commit into
pedrobaeza wants to merge 1 commit into
Conversation
If you have previously sync a `pos.order` (for example, because you have gone to backend with an opened order), and later you do things like unlinking an existing line, you may find other kind of commands in `lines` dictionary like `(2, <id>)`, making the code of this module to crash, so let's protect it properly.
OCA-git-bot
added
series:18.0
mod:pos_sale_picking_keep
victoralmau
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have previously sync a
pos.order(for example, because you have gone to backend with an opened order), and later you do things like unlinking an existing line, you may find other kind of commands inlinesdictionary like(2, <id>), making the code of this module to crash, so let's protect it properly.@Tecnativa