Add splitTestsCompilation solidity setting (10): hardhat-ignition updates#8137
Conversation
|
There was a problem hiding this comment.
Pull request overview
Updates hardhat-ignition’s ignition deploy and ignition visualize tasks to invoke Hardhat’s build task with noTests aligned to the new solidity.splitTestsCompilation setting, and adds regression tests to validate the build invocation args.
Changes:
- Make
ignition visualizepassnoTests: hre.config.solidity.splitTestsCompilationtobuild. - Make
ignition deploypassnoTests: hre.config.solidity.splitTestsCompilationtobuild(keepingdefaultBuildProfile: "production"). - Add tests covering both
splitTestsCompilation: falseandtruefor deploy/visualize build invocations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/hardhat-ignition/src/internal/tasks/visualize.ts | Adjusts build invocation args to respect solidity.splitTestsCompilation. |
| packages/hardhat-ignition/src/internal/tasks/deploy.ts | Adjusts build invocation args to respect solidity.splitTestsCompilation while preserving production build profile usage. |
| packages/hardhat-ignition/test/plan/build-invocation.ts | Adds tests ensuring ignition visualize calls build with the correct noTests value. |
| packages/hardhat-ignition/test/deploy/build-invocation.ts | Adds tests ensuring ignition deploy calls build with the correct noTests value and production profile. |
|
Please ignore the spellcheck failure. The spec file will be deleted before merging. |
fa67bed to
4468e58
Compare
cc2c74c to
9be26a9
Compare
4468e58 to
c2e187e
Compare
9be26a9 to
99fb930
Compare
c2e187e to
5105e8f
Compare
99fb930 to
c968c91
Compare
5105e8f to
50e26fe
Compare
c968c91 to
cd08cc6
Compare
50e26fe to
31970e0
Compare
cd08cc6 to
7a1cec5
Compare
31970e0 to
f0b9340
Compare
7a1cec5 to
a042299
Compare
f0b9340 to
546649a
Compare
a042299 to
db11bbe
Compare
546649a to
5e39826
Compare
db11bbe to
bc64d7a
Compare
5e39826 to
96b513c
Compare
bea3c22 to
70b4ec1
Compare
cd1be43 to
6695e09
Compare
c3ec0c9 to
24ef213
Compare
Just an update to how
buildis run