Skip to content

Add splitTestsCompilation solidity setting (10): hardhat-ignition updates#8137

Merged
alcuadrado merged 2 commits intodont-split-compilationsfrom
dont-split-compilations-phase-10
Apr 16, 2026
Merged

Add splitTestsCompilation solidity setting (10): hardhat-ignition updates#8137
alcuadrado merged 2 commits intodont-split-compilationsfrom
dont-split-compilations-phase-10

Conversation

@alcuadrado
Copy link
Copy Markdown
Member

Just an update to how build is run

@alcuadrado alcuadrado requested a review from Copilot April 12, 2026 22:14
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 12, 2026

⚠️ No Changeset found

Latest commit: 24ef213

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates hardhat-ignition’s ignition deploy and ignition visualize tasks to invoke Hardhat’s build task with noTests aligned to the new solidity.splitTestsCompilation setting, and adds regression tests to validate the build invocation args.

Changes:

  • Make ignition visualize pass noTests: hre.config.solidity.splitTestsCompilation to build.
  • Make ignition deploy pass noTests: hre.config.solidity.splitTestsCompilation to build (keeping defaultBuildProfile: "production").
  • Add tests covering both splitTestsCompilation: false and true for deploy/visualize build invocations.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/hardhat-ignition/src/internal/tasks/visualize.ts Adjusts build invocation args to respect solidity.splitTestsCompilation.
packages/hardhat-ignition/src/internal/tasks/deploy.ts Adjusts build invocation args to respect solidity.splitTestsCompilation while preserving production build profile usage.
packages/hardhat-ignition/test/plan/build-invocation.ts Adds tests ensuring ignition visualize calls build with the correct noTests value.
packages/hardhat-ignition/test/deploy/build-invocation.ts Adds tests ensuring ignition deploy calls build with the correct noTests value and production profile.

@alcuadrado
Copy link
Copy Markdown
Member Author

Please ignore the spellcheck failure. The spec file will be deleted before merging.

@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from fa67bed to 4468e58 Compare April 13, 2026 09:35
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from cc2c74c to 9be26a9 Compare April 13, 2026 09:35
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 4468e58 to c2e187e Compare April 13, 2026 10:32
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from 9be26a9 to 99fb930 Compare April 13, 2026 10:32
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from c2e187e to 5105e8f Compare April 13, 2026 11:07
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from 99fb930 to c968c91 Compare April 13, 2026 11:07
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 5105e8f to 50e26fe Compare April 13, 2026 11:21
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from c968c91 to cd08cc6 Compare April 13, 2026 11:21
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 50e26fe to 31970e0 Compare April 13, 2026 11:39
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from cd08cc6 to 7a1cec5 Compare April 13, 2026 11:40
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 31970e0 to f0b9340 Compare April 13, 2026 12:06
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from 7a1cec5 to a042299 Compare April 13, 2026 12:06
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from f0b9340 to 546649a Compare April 13, 2026 12:46
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from a042299 to db11bbe Compare April 13, 2026 12:46
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 546649a to 5e39826 Compare April 13, 2026 16:28
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from db11bbe to bc64d7a Compare April 13, 2026 16:28
@alcuadrado alcuadrado requested a review from Copilot April 13, 2026 16:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread packages/hardhat-ignition/test/deploy/build-invocation.ts Outdated
@alcuadrado alcuadrado requested a review from Copilot April 13, 2026 18:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from 5e39826 to 96b513c Compare April 13, 2026 19:18
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch 2 times, most recently from bea3c22 to 70b4ec1 Compare April 13, 2026 19:24
@alcuadrado alcuadrado requested a review from Copilot April 13, 2026 19:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-9 branch from cd1be43 to 6695e09 Compare April 13, 2026 19:38
@alcuadrado alcuadrado force-pushed the dont-split-compilations-phase-10 branch from c3ec0c9 to 24ef213 Compare April 13, 2026 19:38
@alcuadrado alcuadrado requested a review from Copilot April 13, 2026 19:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Base automatically changed from dont-split-compilations-phase-9 to dont-split-compilations April 16, 2026 16:38
@alcuadrado alcuadrado merged commit f94b313 into dont-split-compilations Apr 16, 2026
72 checks passed
@alcuadrado alcuadrado deleted the dont-split-compilations-phase-10 branch April 16, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants