Update hardhat-ignition

Author: alcuadrado

packages/hardhat-ignition/src/internal/tasks/deploy.ts

@@ -154,9 +154,10 @@ const taskDeploy: NewTaskActionFunction<TaskDeployArguments> = async (
     );
   }
 
+  const noTests = hre.config.solidity.splitTestsCompilation;
   await hre.tasks.getTask("build").run({
     quiet: true,
-    noTests: true,
+    noTests,
     defaultBuildProfile: "production",
   });
 

packages/hardhat-ignition/src/internal/tasks/visualize.ts

@@ -22,7 +22,8 @@ const visualizeTask: NewTaskActionFunction<TaskVisualizeArguments> = async (
   { noOpen, modulePath }: { noOpen: boolean; modulePath: string },
   hre: HardhatRuntimeEnvironment,
 ) => {
-  await hre.tasks.getTask("build").run({ noTests: true, quiet: true });
+  const noTests = hre.config.solidity.splitTestsCompilation;
+  await hre.tasks.getTask("build").run({ noTests, quiet: true });
 
   const userModule = await loadModule(hre.config.paths.ignition, modulePath);
 

packages/hardhat-ignition/test/deploy/build-invocation.ts

@@ -0,0 +1,111 @@
+import path from "node:path";
+import { fileURLToPath, pathToFileURL } from "node:url";
+
+import { assert } from "chai";
+import { overrideTask } from "hardhat/config";
+import { createHardhatRuntimeEnvironment } from "hardhat/hre";
+
+import hardhatIgnitionPlugin from "../../src/index.js";
+
+describe("deploy - build invocation", function () {
+  function buildArgCaptor() {
+    const buildArgs: any[] = [];
+    const buildOverride = overrideTask("build")
+      .setAction(async () => ({
+        default: async (args: any) => {
+          buildArgs.push(args);
+          return { contractRootPaths: [], testRootPaths: [] };
+        },
+      }))
+      .build();
+    return { buildArgs, buildOverride };
+  }
+
+  function getProjectConfig() {
+    const projectPath = path.join(
+      path.dirname(fileURLToPath(import.meta.url)),
+      "../fixture-projects",
+      "minimal",
+    );
+
+    const configPath = path.join(projectPath, "hardhat.config.js");
+
+    return { projectPath, configPath };
+  }
+
+  it("should call build without noTests when splitTestsCompilation is false", async function () {
+    const { buildArgs, buildOverride } = buildArgCaptor();
+    const { projectPath, configPath } = getProjectConfig();
+
+    const { default: userConfig } = await import(
+      pathToFileURL(configPath).href
+    );
+
+    const hre = await createHardhatRuntimeEnvironment(
+      {
+        ...userConfig,
+        plugins: [hardhatIgnitionPlugin],
+        tasks: [buildOverride],
+      },
+      { config: configPath },
+      projectPath,
+    );
+
+    // The deploy task continues after build and may fail looking for artifacts;
+    // we only care about the build invocation args captured before that point.
+    try {
+      await hre.tasks.getTask(["ignition", "deploy"]).run({
+        modulePath: path.join(
+          projectPath,
+          "ignition",
+          "modules",
+          "MyModule.js",
+        ),
+      });
+    } catch {}
+
+    assert.equal(buildArgs.length, 1);
+    assert.equal(buildArgs[0].noTests, false);
+    assert.equal(buildArgs[0].defaultBuildProfile, "production");
+    assert.equal(buildArgs[0].quiet, true);
+  });
+
+  it("should call build with noTests when splitTestsCompilation is true", async function () {
+    const { buildArgs, buildOverride } = buildArgCaptor();
+    const { projectPath, configPath } = getProjectConfig();
+
+    const { default: userConfig } = await import(
+      pathToFileURL(configPath).href
+    );
+
+    const hre = await createHardhatRuntimeEnvironment(
+      {
+        ...userConfig,
+        solidity: {
+          ...userConfig.solidity,
+          splitTestsCompilation: true,
+        },
+        plugins: [hardhatIgnitionPlugin],
+        tasks: [buildOverride],
+      },
+      { config: configPath },
+      projectPath,
+    );
+
+    try {
+      await hre.tasks.getTask(["ignition", "deploy"]).run({
+        modulePath: path.join(
+          projectPath,
+          "ignition",
+          "modules",
+          "MyModule.js",
+        ),
+      });
+    } catch {}
+
+    assert.equal(buildArgs.length, 1);
+    assert.equal(buildArgs[0].noTests, true);
+    assert.equal(buildArgs[0].defaultBuildProfile, "production");
+    assert.equal(buildArgs[0].quiet, true);
+  });
+});

packages/hardhat-ignition/test/plan/build-invocation.ts

@@ -0,0 +1,95 @@
+import path from "node:path";
+import { fileURLToPath, pathToFileURL } from "node:url";
+
+import { assert } from "chai";
+import { overrideTask } from "hardhat/config";
+import { createHardhatRuntimeEnvironment } from "hardhat/hre";
+
+import hardhatIgnitionPlugin from "../../src/index.js";
+
+describe("visualize - build invocation", function () {
+  function buildArgCaptor() {
+    const buildArgs: any[] = [];
+    const buildOverride = overrideTask("build")
+      .setAction(async () => ({
+        default: async (args: any) => {
+          buildArgs.push(args);
+          return { contractRootPaths: [], testRootPaths: [] };
+        },
+      }))
+      .build();
+    return { buildArgs, buildOverride };
+  }
+
+  function getProjectConfig() {
+    const projectPath = path.join(
+      path.dirname(fileURLToPath(import.meta.url)),
+      "../fixture-projects",
+      "minimal",
+    );
+
+    const configPath = path.join(projectPath, "hardhat.config.js");
+
+    return { projectPath, configPath };
+  }
+
+  it("should call build without noTests when splitTestsCompilation is false", async function () {
+    const { buildArgs, buildOverride } = buildArgCaptor();
+    const { projectPath, configPath } = getProjectConfig();
+
+    const { default: userConfig } = await import(
+      pathToFileURL(configPath).href
+    );
+
+    const hre = await createHardhatRuntimeEnvironment(
+      {
+        ...userConfig,
+        plugins: [hardhatIgnitionPlugin],
+        tasks: [buildOverride],
+      },
+      { config: configPath },
+      projectPath,
+    );
+
+    await hre.tasks.getTask(["ignition", "visualize"]).run({
+      noOpen: true,
+      modulePath: path.join(projectPath, "ignition", "modules", "MyModule.js"),
+    });
+
+    assert.equal(buildArgs.length, 1);
+    assert.equal(buildArgs[0].noTests, false);
+    assert.equal(buildArgs[0].quiet, true);
+  });
+
+  it("should call build with noTests when splitTestsCompilation is true", async function () {
+    const { buildArgs, buildOverride } = buildArgCaptor();
+    const { projectPath, configPath } = getProjectConfig();
+
+    const { default: userConfig } = await import(
+      pathToFileURL(configPath).href
+    );
+
+    const hre = await createHardhatRuntimeEnvironment(
+      {
+        ...userConfig,
+        solidity: {
+          ...userConfig.solidity,
+          splitTestsCompilation: true,
+        },
+        plugins: [hardhatIgnitionPlugin],
+        tasks: [buildOverride],
+      },
+      { config: configPath },
+      projectPath,
+    );
+
+    await hre.tasks.getTask(["ignition", "visualize"]).run({
+      noOpen: true,
+      modulePath: path.join(projectPath, "ignition", "modules", "MyModule.js"),
+    });
+
+    assert.equal(buildArgs.length, 1);
+    assert.equal(buildArgs[0].noTests, true);
+    assert.equal(buildArgs[0].quiet, true);
+  });
+});