Skip to content

Fix inconsistencies in service toggle and TLS conditionals #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alja9 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

Fix inconsistencies in service toggle and TLS conditionals #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deployment/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ spec:
- name: "pod-gpu-resources"
hostPath:
path: {{ .Values.kubeletPath }}
{{- if and .Values.tlsServerConfig.enabled }}
{{- if .Values.tlsServerConfig.enabled }}
- name: "tls"
secret:
secretName: {{ include "dcgm-exporter.tlsCertsSecretName" . }}
Expand Down Expand Up @@ -170,7 +170,7 @@ spec:
- name: "pod-gpu-resources"
readOnly: true
mountPath: "/var/lib/kubelet/pod-resources"
{{- if and .Values.tlsServerConfig.enabled }}
{{- if .Values.tlsServerConfig.enabled }}
- name: "tls"
mountPath: /etc/dcgm-exporter/tls
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion deployment/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.service.enable }}
{{- if .Values.service.enabled }}
# Copyright (c) 2021, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
4 changes: 2 additions & 2 deletions deployment/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ serviceAccount:
rollingUpdate:
# Specifies maximum number of DaemonSet pods that can be unavailable during the update
maxUnavailable: 1
# Specifies maximum number of nodes with an existing available DaemonSet pod that can have an updated DaemonSet pod during during an update
# Specifies maximum number of nodes with an existing available DaemonSet pod that can have an updated DaemonSet pod during an update
maxSurge: 0

# Labels to be added to dcgm-exporter pods
Expand Down Expand Up @@ -106,7 +106,7 @@ securityContext:
# Defines the dcgm-exporter service
service:
# When enabled, the helm chart will create service
enable: true
enabled: true
type: ClusterIP
# Accepts either "Cluster" or "Local", choose Local if you want to route internal traffic within the node only
internalTrafficPolicy: Cluster
Expand Down