Fix inconsistencies in service toggle and TLS conditionals#669
Open
Alja9 wants to merge 1 commit into
Open
Conversation
- Rename service.enable to service.enabled for consistency with other feature toggles in the chart - Remove redundant 'and' operator from TLS conditionals in daemonset.yaml for Helm best practice Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
Alja9
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR for fixing the chart
Rename
service.enabletoservice.enabledfor consistency with other feature toggles in the chart.All other feature toggles in the chart use
enabled(e.g.,serviceMonitor.enabled,debugDump.enabled,tlsServerConfig.enabled,kubernetesDRA.enabled). Usingenablefor the service is inconsistent and can cause confusion for users expecting the same naming pattern. This change aligns it with the rest of the chart.Remove redundant
andoperator fromTLSconditionals indaemonset.yaml.Uses the
andoperator with only one operand, which is redundant,andis meant to combine multiple conditions.