Check dig result properly#638
Merged
Merged
Conversation
As it doesn't exit with code non-zero if a DNS error response message is received.
tertsdiepraam
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSIG response signing is actually failing but wasn't detected by the
downstream-tsigsystem test due to wrongly assuming thatdigwould exit with a non-zero exit code if there is a problem with the response. However, dig will exit with code 0 if it receives any DNS response, success or failure.This PR makes the dig check stricter. The dig check was also failing to use the TSIG key when it should which this PR also fixes.
This test detects the TSIG failure but doesn't fix it. PR #637 has been tested with this PR and causes the TSIG error reported by
digto disappear.Cargo.*,crates/,etc/,integration-tests/,src/):actthrough theact-wrapper(as described inTESTING.md)?