Fix the position of Tsig in the service layers.#637
Merged
Conversation
ximon18
approved these changes
May 8, 2026
Member
ximon18
left a comment
ximon18
left a comment
There was a problem hiding this comment.
The downstream-tsig system test should be failing because of the problem that this PR fixes, but due to a bug in the test that failure went unnoticed. PR #638 fixes the downstream-tsig system test so that it correctly fails. I tested that this PR then makes the system test work again by fixing the underlying problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.