GEOPY-2910: reverting changes - introduced slowness#160
Open
sebhmg wants to merge 2 commits into
Open
Conversation
…te_release" This reverts commit f93e8b3.
sebhmg
changed the title
github-actions
Bot
changed the title
sebhmg
changed the title
Closed
There was a problem hiding this comment.
Pull request overview
This PR updates the Dask TDEM sensitivity (compute_J) workflow to change how field-derivative blocks are stored/propagated between timesteps, aiming to reduce sensitivity “chunking” overhead during TEM inversions.
Changes:
- Enables default
get_parallel_blocksoptimization by removingoptimize=False. - Refactors field-derivative back-substitution to operate on per-chunk arrays (list-of-arrays) instead of assembling a single stacked block.
- Updates
compute_rowsto consume the new per-chunkfield_derivsstructure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
166
to
172
|
|
||
| for block_ind in range(len(blocks)): | ||
|
|
||
| if len(blocks[block_ind]) == 0: | ||
| if len(block) == 0: | ||
| continue | ||
|
|
||
| if client: |
Comment on lines
336
to
341
| tInd: int, | ||
| AdiagTinv, | ||
| ATinv_df_duT_v, | ||
| time_mask, | ||
| client, | ||
| ): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert GEOPY-2910 - Reduce chunking of sensitivities for TEM inversions
introduced slowness