GEOPY-2910: reverting changes - introduced slowness#158
Merged
Conversation
…release" This reverts commit f93e8b3.
This was referenced Jun 20, 2026
Closed
sebhmg
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the Dask-backed TDEM sensitivity workflow in Sim.compute_J, changing how parallel blocks are created and how field-derivative blocks are propagated across timesteps.
Changes:
- Removes the explicit
optimize=Falseargument when building parallel blocks viaget_parallel_blocks. - Refactors field-derivative back-substitution to operate on per-chunk arrays (list-of-arrays) rather than a single stacked 2D array.
- Updates row-assembly logic in
compute_rowsto index per-chunk derivatives directly (removing column-offset bookkeeping).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
167
to
170
| for block_ind in range(len(blocks)): | ||
|
|
||
| if len(blocks[block_ind]) == 0: | ||
| if len(block) == 0: | ||
| continue |
Comment on lines
157
to
160
| ATinv_df_duT_v[ind], | ||
| time_mask, | ||
| client, | ||
| ) |
Comment on lines
338
to
341
| ATinv_df_duT_v, | ||
| time_mask, | ||
| client, | ||
| ): |
sebhmg
changed the title
Author
|
messed up history with wrong issue number. Reset release/GA_4.8 again: new PR here #160 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert GEOPY-2910 - Reduce chunking of sensitivities for TEM inversions
introduced slowness