GEOPY-2910: reverting changes - introduced slowness#157
Merged
Conversation
Revert "GEOPY-2910: Reduce chunking of sensitivities for TEM inversions"
Revert "GEOPY-2910: Reduce chunking of sensitivities for TEM inversions"
There was a problem hiding this comment.
Pull request overview
This PR aims to revert/adjust recent changes in the Dask TDEM sensitivity (compute_J) implementation that introduced slowness, primarily by changing how parallel blocks are generated and how field-derivative back-substitution is accumulated per block/chunk.
Changes:
- Removes
optimize=Falsefromget_parallel_blocks(...), allowing the default optimization behavior again. - Refactors
get_field_deriv_block(...)to updateATinv_df_duT_vper chunk (instead of stacking/hstacking across chunks), and updates downstream indexing incompute_rows(...). - Threads
clientthrough toget_field_deriv_block(...)(currently passed through as an argument).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
167
to
170
| for block_ind in range(len(blocks)): | ||
|
|
||
| if len(blocks[block_ind]) == 0: | ||
| if len(block) == 0: | ||
| continue |
Author
|
branch history is missing reference to revert commits. I have reset release/GA_4.8, and I am redoing a clean revert here: #158 |
sebhmg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert GEOPY-2910 - Reduce chunking of sensitivities for TEM inversions
introduced slowness